linux-kernel - Re: [PATCH] iomap: Fix conflicting values of iomap flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250328104750.GA19460@lst.de>
Date: Fri, 28 Mar 2025 11:47:50 +0100
From: Christoph Hellwig <hch@....de>
To: "Ritesh Harjani (IBM)" <ritesh.list@...il.com>
Cc: linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Christoph Hellwig <hch@....de>,
	John Garry <john.g.garry@...cle.com>, brauner@...nel.org,
	djwong@...nel.org, dchinner@...hat.com,
	linux-kernel@...r.kernel.org, ojaswin@...ux.ibm.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] iomap: Fix conflicting values of iomap flags

On Fri, Mar 28, 2025 at 01:01:19AM +0800, Ritesh Harjani (IBM) wrote:
> IOMAP_F_ATOMIC_BIO mistakenly took the same value as of IOMAP_F_SIZE_CHANGED
> in patch '370a6de7651b ("iomap: rework IOMAP atomic flags")'.
> Let's fix this and let's also create some more space for filesystem reported
> flags to avoid this in future. This patch makes the core iomap flags to start
> from bit 15, moving downwards. Note that "flags" member within struct iomap
> is of type u16.
> 
> Fixes: 370a6de7651b ("iomap: rework IOMAP atomic flags")
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>