linux-kernel - Re: [main-line]Build warnings on PowerPC system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e18df940-bb30-44c9-9384-7325e8d02d25@linux.ibm.com>
Date: Fri, 28 Mar 2025 16:44:41 +0530
From: Madhavan Srinivasan <maddy@...ux.ibm.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
        Venkat Rao Bagalkote <venkat88@...ux.ibm.com>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [main-line]Build warnings on PowerPC system


>>> diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
>>> index 1db60fe13802..09ceb5a42d81 100755
>>> --- a/arch/powerpc/boot/wrapper
>>> +++ b/arch/powerpc/boot/wrapper
>>> @@ -235,7 +235,7 @@ fi
>>>   # suppress some warnings in recent ld versions
>>>   nowarn="-z noexecstack"
>>>   if ! ld_is_lld; then
>>> -       if [ "$LD_VERSION" -ge "$(echo 2.39 | ld_version)" ]; then
>>> +       if [ "$LD_VERSION" -ge "$(echo 2.35 | ld_version)" ]; then
>>>                  nowarn="$nowarn --no-warn-rwx-segments"
>>>          fi
>>>   fi
>> Above change fixes the issue. No warnings observed. Thank you!!
> 
> Take care, this must be a special version of binutils.
> 
> With regular 2.36.1 I get following error:
> 
> $ /opt/gcc/gcc-8.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version
> GNU ld (GNU Binutils) 2.36.1
> Copyright (C) 2021 Free Software Foundation, Inc.
> This program is free software; you may redistribute it under the terms of
> the GNU General Public License version 3 or (at your option) a later version.
> This program has absolutely no warranty.
> 
> $ /opt/gcc/gcc-8.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --no-warn-rwx-segments test.o
> /opt/gcc/gcc-8.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: unrecognized option '--no-warn-rwx-segments'
> /opt/gcc/gcc-8.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: use the --help option for usage information
> 

Nice catch. Thanks Christophe.

May be we need to handle this special/specific case with an
additional check

diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index 1db60fe13802..d3779c20e548 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -237,6 +237,8 @@ nowarn="-z noexecstack"
 if ! ld_is_lld; then
        if [ "$LD_VERSION" -ge "$(echo 2.39 | ld_version)" ]; then
                nowarn="$nowarn --no-warn-rwx-segments"
+        elif [ "$LD_VERSION" -eq "235020000" ]; then
+                nowarn="$nowarn --no-warn-rwx-segments"
        fi
 fi

 
Maddy