linux-kernel - Re: [PATCH 2/3] rust: dma: convert the read/write macros to return Result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2c36d1e-cde0-420e-a19a-fda479d79572@gmail.com>
Date: Fri, 28 Mar 2025 13:17:06 +0200
From: Abdiel Janulgue <abdiel.janulgue@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 "a.hindborg@...nel.org" <a.hindborg@...nel.org>
Cc: a.hindborg@...nel.org, ojeda@...nel.org,
 Danilo Krummrich <dakr@...nel.org>,
 Daniel Almeida <daniel.almeida@...labora.com>,
 Robin Murphy <robin.murphy@....com>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 "open list:DMA MAPPING HELPERS DEVICE DRIVER API [RUST]"
 <rust-for-linux@...r.kernel.org>, Marek Szyprowski
 <m.szyprowski@...sung.com>,
 "open list:DMA MAPPING HELPERS" <iommu@...ts.linux.dev>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] rust: dma: convert the read/write macros to return
 Result



On 26/03/2025 22:48, Miguel Ojeda wrote:
> On Wed, Mar 26, 2025 at 9:13 PM Abdiel Janulgue
> <abdiel.janulgue@...il.com> wrote:
>>
>> As suggested by Andreas Hindborg, we could do better here by
>> having the macros return `Result`, so that we don't have to wrap
>> these calls in a closure for validation which is confusing.
>>
>> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@...il.com>
> 
> I would suggest:
> 
> Suggested-by: Andreas Hindborg <a.hindborg@...nel.org>
> Link: https://lore.kernel.org/rust-for-linux/87h63qhz4q.fsf@kernel.org/
> 
> Maybe also consider if Co-developed-by etc. makes sense since he
> provided the diff.

Thanks! Andreas, would you be okay if I add the Co-developed-by tag?

Regards,
Abdiel