linux-kernel - Re: [PATCH 2/2] mm: mincore: use folio_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-afwA3UyEJxryBp@localhost.localdomain>
Date: Fri, 28 Mar 2025 14:10:24 +0100
From: Oscar Salvador <osalvador@...e.de>
To: Ryan Roberts <ryan.roberts@....com>
Cc: Baolin Wang <baolin.wang@...ux.alibaba.com>, akpm@...ux-foundation.org,
	hughd@...gle.com, willy@...radead.org, david@...hat.com,
	21cnbao@...il.com, ziy@...dia.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: mincore: use folio_pte_batch() to batch process
 large folios

On Thu, Mar 27, 2025 at 10:08:56AM -0400, Ryan Roberts wrote:
> You could simplify to the following, I think, to avoid needing to grab the folio
> and call folio_pte_batch():
> 
> 			else if (pte_present(pte)) {
> 				int max_nr = (end - addr) / PAGE_SIZE;
> 				step = min(pte_batch_hint(ptep, pte), max_nr);
> 			} ...

Yes, I think this makes much more sense, in the end, as you said, we do
not really need what folio_pte_batch gives us here.

With the API I am working on, batching will be done in there internally,
so we will not have to expose this here.

-- 
Oscar Salvador
SUSE Labs