linux-kernel - Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66d344b9-5cc6-4060-86ff-8100a00de477@web.de>
Date: Fri, 28 Mar 2025 14:19:39 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>,
 linux-i3c@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Bjorn Andersson <andersson@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

…
> +++ b/drivers/i3c/master/qcom-i3c-master.c
> @@ -0,0 +1,1107 @@
…
> +static void geni_i3c_abort_xfer(struct geni_i3c_dev *gi3c)
> +{
…
> +	spin_lock_irqsave(&gi3c->irq_lock, flags);
> +	geni_i3c_handle_err(gi3c, GENI_TIMEOUT);
> +	geni_se_abort_m_cmd(&gi3c->se);
> +	spin_unlock_irqrestore(&gi3c->irq_lock, flags);
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&gi3c->irq_lock);”?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/spinlock.h#L572

Regards,
Markus