linux-kernel - Re: [PATCH] RDMA/mlx5: hide unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <cdaf0e11-3de2-4979-8112-7865c63c0ffd@app.fastmail.com>
Date: Fri, 28 Mar 2025 14:20:30 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jason Gunthorpe" <jgg@...pe.ca>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Leon Romanovsky" <leon@...nel.org>,
 "Patrisious Haddad" <phaddad@...dia.com>, "Mark Bloch" <mbloch@...dia.com>,
 "Tariq Toukan" <tariqt@...dia.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Moshe Shemesh" <moshe@...dia.com>, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: hide unused code

On Fri, Mar 28, 2025, at 14:15, Jason Gunthorpe wrote:
> On Fri, Mar 28, 2025 at 02:10:17PM +0100, Arnd Bergmann wrote:
>
> IDK, I'm tempted to revert 36e0d433672f ("RDMA/mlx5: Compile fs.c
> regardless of INFINIBAND_USER_ACCESS config")
>
> I don't think that was so well thought out. The entire file was
> designed to be USER_ACCESS only because it uses all this mechanism.
>
> #ifdefing away half the file seems ugly.

That sounds better to me, yes. I assumed that a later patch
required that one, but I don't see such a dependency.

     Arnd