linux-kernel - Re: [PATCH 2/3] ieee802154: Avoid calling WARN_ON() on -ENOMEM in cfg802154_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250328023029.14249-1-kuniyu@amazon.com>
Date: Thu, 27 Mar 2025 19:30:02 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <i.abramov@...integration.ru>
CC: <alex.aring@...il.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<horms@...nel.org>, <kuba@...nel.org>, <kuniyu@...zon.com>,
	<linux-kernel@...r.kernel.org>, <linux-wpan@...r.kernel.org>,
	<lvc-project@...uxtesting.org>, <miquel.raynal@...tlin.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <stefan@...enfreihafen.org>,
	<syzbot+e0bd4e4815a910c0daa8@...kaller.appspotmail.com>
Subject: Re: [PATCH 2/3] ieee802154: Avoid calling WARN_ON() on -ENOMEM in cfg802154_switch_netns()

From: Ivan Abramov <i.abramov@...integration.ru>
Date: Fri, 28 Mar 2025 04:04:26 +0300
> It's pointless to call WARN_ON() in case of an allocation failure in
> dev_change_net_namespace() and device_rename(), since it only leads to
> useless splats caused by deliberate fault injections, so avoid it.
> 
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
> 
> Fixes: 66e5c2672cd1 ("ieee802154: add netns support")
> Suggested-by: Kuniyuki Iwashima <kuniyu@...zon.com>

I suggested using net_warn_ratelimited() so this tag is not needed.
The patch itself looks good to me:

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>


> Signed-off-by: Ivan Abramov <i.abramov@...integration.ru>

Reported-by: syzbot+e0bd4e4815a910c0daa8@...kaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/000000000000f4a1b7061f9421de@google.com/#t