linux-kernel - Re: [patch V2 09/10] scsi: ufs: qcom: Remove the MSI descriptor abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tt7dw8ro.ffs@tglx>
Date: Fri, 28 Mar 2025 15:05:15 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Marc Zyngier <maz@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, "James E.J.
 Bottomley" <James.Bottomley@...senpartnership.com>, "Martin K. Petersen"
 <martin.petersen@...cle.com>, linux-scsi@...r.kernel.org, Peter Zijlstra
 <peterz@...radead.org>, Nishanth Menon <nm@...com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, Dhruva Gole <d-gole@...com>, Tero Kristo
 <kristo@...nel.org>, Santosh Shilimkar <ssantosh@...nel.org>, Logan
 Gunthorpe <logang@...tatee.com>, Dave Jiang <dave.jiang@...el.com>, Jon
 Mason <jdmason@...zu.us>, Allen Hubbe <allenbh@...il.com>,
 ntb@...ts.linux.dev, Bjorn Helgaas <bhelgaas@...gle.com>,
 linux-pci@...r.kernel.org, Michael Kelley <mhklinux@...look.com>, Wei Liu
 <wei.liu@...nel.org>, Haiyang Zhang <haiyangz@...rosoft.com>,
 linux-hyperv@...r.kernel.org, Wei Huang <wei.huang2@....com>, Jonathan
 Cameron <Jonathan.Cameron@...ei.com>
Subject: Re: [patch V2 09/10] scsi: ufs: qcom: Remove the MSI descriptor abuse

On Fri, Mar 28 2025 at 13:00, Dan Carpenter wrote:
> On Thu, Mar 13, 2025 at 02:03:51PM +0100, Thomas Gleixner wrote:
>> @@ -1799,8 +1803,7 @@ static irqreturn_t ufs_qcom_mcq_esi_hand
>>  static int ufs_qcom_config_esi(struct ufs_hba *hba)
>>  {
>>  	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
>> -	struct msi_desc *desc;
>> -	struct msi_desc *failed_desc = NULL;
>> +	struct ufs_qcom_irq *qi;
>>  	int nr_irqs, ret;
>>  
>>  	if (host->esi_enabled)
>> @@ -1811,47 +1814,47 @@ static int ufs_qcom_config_esi(struct uf
>>  	 * 2. Poll queues do not need ESI.
>>  	 */
>>  	nr_irqs = hba->nr_hw_queues - hba->nr_queues[HCTX_TYPE_POLL];
>> +	qi = devm_kcalloc(hba->dev, nr_irqs, sizeof(*qi), GFP_KERNEL);
>> +	if (qi)
>
> This NULL check is reversed.  Missing !.

Duh. I'm sure I've fixed that before.