linux-kernel - Re: [PATCH v2 2/3] nvme/ioctl: don't call blk_mq_free_request() in nvme_map_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADUfDZrqrAQzcf14B1ZxJoxVWOg2giXNCop18WG=62eMEHO7Mg@mail.gmail.com>
Date: Thu, 27 Mar 2025 19:48:11 -0700
From: Caleb Sander Mateos <csander@...estorage.com>
To: Christoph Hellwig <hch@....de>
Cc: Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>, Sagi Grimberg <sagi@...mberg.me>, 
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] nvme/ioctl: don't call blk_mq_free_request() in nvme_map_user_request()

On Thu, Mar 27, 2025 at 3:42 AM Christoph Hellwig <hch@....de> wrote:
>
> On Fri, Mar 21, 2025 at 02:57:21PM -0600, Caleb Sander Mateos wrote:
> >       ret = nvme_execute_rq(req, false);
> >       if (result)
> >               *result = le64_to_cpu(nvme_req(req)->result.u64);
> >       if (bio)
> >               blk_rq_unmap_user(bio);
> > -     blk_mq_free_request(req);
> >
> >       if (effects)
> >               nvme_passthru_end(ctrl, ns, effects, cmd, ret);
> >
> > +out_free_req:
> > +     blk_mq_free_request(req);
>
> We'll want the request freed before nvme_passthru_end here to avoid
> deadlocks with namespaces scanning.

Good point, I'll send out a v4.

Thanks,
Caleb