linux-kernel - Re: Fw: [PATCH] netlabel: Fix NULL pointer exception caused by CALIPSO on IPv4 sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhTRUAV6P17TfXoODwowpAHwnhhLai6naVE300Y76Kk40Q@mail.gmail.com>
Date: Fri, 28 Mar 2025 11:50:43 -0400
From: Paul Moore <paul@...l-moore.com>
To: "mowenroot@....com" <mowenroot@....com>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev <netdev@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, Bitao Ouyang <1985755126@...com>
Subject: Re: Fw: [PATCH] netlabel: Fix NULL pointer exception caused by
 CALIPSO on IPv4 sockets

On Wed, Mar 26, 2025 at 11:05 PM mowenroot@....com <mowenroot@....com> wrote:
> On Thu, Mar 27, 2025 at 3:38 AM Paul Moore paul@...l-moore.com wrote:
>
> > For all three function, I'd probably add a single blank line between the local variable declarations and the code below for the sake of readability. I'd probably also drop the comment as the code seems reasonably obvious (inet6_sk() can return NULL, we can't do anything with a NULL ptr so bail), but neither are reasons for not applying this patch, if anything they can be fixed up during the merge assuming the patch author agrees.
> >
> > Anyway, this looks good to me, Jakub and/or other netdev folks, we should get this marked for stable and sent up to Linus, do you want to do that or should I?
>
> Thank you for your acknowledgment and suggestions! Your insights have been very helpful to us.
>
> We fully agree with your suggestions regarding code formatting and comment adjustments. Since you are more familiar with the code, we would appreciate it if you could help handle these modifications and complete the merge. If you are willing to do so, we would be very grateful!
>
> Previously, the email failed to be delivered to netdev@...r.kernel.org and linux-kernel@...r.kernel.org due to formatting issues. We sincerely apologize for any inconvenience this may have caused.

Most (all?) of the Linux kernel mailing lists have requirements around
only sending plaintext email, no HTML, no MIME, etc.; I believe that
was the issue with some of your email to the lists.

The Linux kernel documentation does have some guidance on configuring
popular email clients as well as submitting patches, you can browse
the documentation online (relevant links below).

https://docs.kernel.org/process/submitting-patches.html
https://docs.kernel.org/process/email-clients.html

> Thank you again for your guidance and support. We are delighted to learn from you!

Thanks for the problem report and your help with finding and testing a
solution :)

-- 
paul-moore.com