linux-kernel - Re: [PATCH] rust: Fix enabling Rust and building with GCC for LoongArch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=AZ+CN4SScZcnRBpkS8ogCaZ=Uhe=k7fhGCVyecyRu5g@mail.gmail.com>
Date: Fri, 28 Mar 2025 17:15:04 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: Xi Ruoyao <xry111@...111.site>, WANG Rui <wangrui@...ngson.cn>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev, 
	loongson-kernel@...ts.loongnix.cn, stable@...r.kernel.org
Subject: Re: [PATCH] rust: Fix enabling Rust and building with GCC for LoongArch

On Tue, Mar 4, 2025 at 10:12 AM Huacai Chen <chenhuacai@...nel.org> wrote:
>
> Don't rely on  default behavior, things may change in future.
> Acked-by: Huacai Chen <chenhuacai@...ngson.cn>

I was pinged about this one -- are you picking this one through your tree?

I didn't test it, but the change seems safe to me for other
architectures that we have at the moment, since they don't seem to set
any of those three from a quick look, so:

Acked-by: Miguel Ojeda <ojeda@...nel.org>

In any case, the usual question for these "skipped flags" is whether
they could affect the output of `bindgen`, i.e. could they modify
layouts somehow?

Also, it would be nice to mention a bit more what was the build error
and the GCC version in the commit message.

Finally, regarding the Cc: stable, I guess that means 6.12+ since it
is the first LTS with loongarch64, right?

Thanks!

Cheers,
Miguel