linux-kernel - Re: [PATCH v2] powerpc/boot: Fix build with gcc 15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xjsjj6b.fsf@mpe.ellerman.id.au>
Date: Sat, 29 Mar 2025 20:11:08 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Michal Suchanek <msuchanek@...e.de>, linuxppc-dev@...ts.ozlabs.org
Cc: Michal Suchanek <msuchanek@...e.de>, Madhavan Srinivasan
 <maddy@...ux.ibm.com>, Nicholas Piggin <npiggin@...il.com>, Christophe
 Leroy <christophe.leroy@...roup.eu>, Naveen N Rao <naveen@...nel.org>,
 Nicolas Schier <nicolas@...sle.eu>, Masahiro Yamada
 <masahiroy@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 linux-kernel@...r.kernel.org, "Nysal Jan K.A." <nysal@...ux.ibm.com>
Subject: Re: [PATCH v2] powerpc/boot: Fix build with gcc 15

Michal Suchanek <msuchanek@...e.de> writes:
> Similar to x86 the ppc boot code does not build with GCC 15.
>
> Copy the fix from
> commit ee2ab467bddf ("x86/boot: Use '-std=gnu11' to fix build with GCC 15")
>
> Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> ---
> v2: Move the fix outside of ifdef to apply to all subarchitectures
> ---
>  arch/powerpc/boot/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> index 1ff6ad4f6cd2..210c60d3d4cc 100644
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -32,6 +32,8 @@ else
>      BOOTAR := $(AR)
>  endif
>  
> +BOOTTARGETFLAGS	+= -std=gnu11
> +
 
BOOTTARGETFLAGS gets added to CFLAGS and AFLAGS.

I think -std=gnu11 should only be added to CFLAGS. In which case it'd be
better to add it directly to BOOTCFLAGS further down.

cheers