linux-kernel - Re: [PATCH] mmc: renesas_sdhi: add regulator dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-fBYVzkxZOqZixB@shikoro>
Date: Sat, 29 Mar 2025 10:46:09 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>,
	Biju Das <biju.das.jz@...renesas.com>,
	Arnd Bergmann <arnd@...db.de>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: renesas_sdhi: add regulator dependency

On Sat, Mar 29, 2025 at 09:20:52AM +0100, Arnd Bergmann wrote:

>  config MMC_SDHI
>  	tristate "Renesas SDHI SD/SDIO controller support"
> -	depends on SUPERH || ARCH_RENESAS || COMPILE_TEST
> +	depends on SUPERH || (ARCH_RENESAS && RESET_CONTROLLER) || COMPILE_TEST
> +	depends on REGULATOR

Hmm, this is too strict IMO. SuperH does not need REGULATOR. But adding
REGULATOR to ARCH_RENESAS like RESET_CONTROLLER will still fail for
COMPILE_TEST, right?

Maybe we need to maintain the dependency in Kconfig after all:

	depends on REGULATOR if ARCH_R8A<whichever needs it>
?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)