linux-kernel - Re: [PATCH] dt-bindings: gpio: Correct indentation and style in DTS example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <27075369f1d53f840965a09601e10b130f622d16.camel@svanheule.net>
Date: Sat, 29 Mar 2025 10:53:45 +0100
From: Sander Vanheule <sander@...nheule.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Linus Walleij	
 <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Rob
 Herring	 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley	 <conor+dt@...nel.org>, Nicolas Ferre <nicolas.ferre@...rochip.com>,
  Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea
 <claudiu.beznea@...on.dev>, Shawn Guo	 <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Paul Walmsley	
 <paul.walmsley@...ive.com>, Samuel Holland <samuel.holland@...ive.com>, 
 Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>, Shubhrajyoti Datta
 <shubhrajyoti.datta@....com>, Srinivas Neeli	 <srinivas.neeli@....com>,
 Michal Simek <michal.simek@....com>, Geert Uytterhoeven
 <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, Manikandan
 Muralidharan	 <manikandan.m@...rochip.com>, Maxime Ripard
 <mripard@...nel.org>, Laurent Pinchart
 <laurent.pinchart+renesas@...asonboard.com>, Bert Vermeulen
 <bert@...t.com>, 	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	imx@...ts.linux.dev, linux-riscv@...ts.infradead.org, 
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: gpio: Correct indentation and style in DTS
 example

Hi Krysztof,

On Mon, 2025-03-24 at 13:53 +0100, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.  While re-indenting, drop
> unused labels.
> 
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  .../bindings/gpio/atmel,at91rm9200-gpio.yaml  | 16 ++---
>  .../bindings/gpio/fairchild,74hc595.yaml      | 20 +++---
>  .../devicetree/bindings/gpio/gpio-mxs.yaml    | 70 +++++++++----------
>  .../devicetree/bindings/gpio/nxp,pcf8575.yaml | 24 +++----
>  .../bindings/gpio/realtek,otto-gpio.yaml      |  8 +--
>  .../bindings/gpio/renesas,em-gio.yaml         | 20 +++---
>  .../bindings/gpio/renesas,rcar-gpio.yaml      | 24 +++----
>  .../devicetree/bindings/gpio/sifive,gpio.yaml |  6 +-
>  .../bindings/gpio/toshiba,gpio-visconti.yaml  | 24 +++----
>  .../bindings/gpio/xlnx,gpio-xilinx.yaml       | 48 ++++++-------
>  10 files changed, 130 insertions(+), 130 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> index 39fd959c45d2..728099c65824 100644
> --- a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> @@ -81,7 +81,7 @@ dependencies:
>  
>  examples:
>    - |
> -      gpio@...0 {
> +    gpio@...0 {
>          compatible = "realtek,rtl8380-gpio", "realtek,otto-gpio";
>          reg = <0x3500 0x1c>;
>          gpio-controller;
> @@ -91,9 +91,9 @@ examples:
>          #interrupt-cells = <2>;
>          interrupt-parent = <&rtlintc>;
>          interrupts = <23>;
> -      };
> +    };
>    - |
> -      gpio@...0 {
> +    gpio@...0 {
>          compatible = "realtek,rtl9300-gpio", "realtek,otto-gpio";
>          reg = <0x3300 0x1c>, <0x3338 0x8>;
>          gpio-controller;
> @@ -103,6 +103,6 @@ examples:
>          #interrupt-cells = <2>;
>          interrupt-parent = <&rtlintc>;
>          interrupts = <13>;
> -      };
> +    };
>  
>  ...

FWIW

Reviewed-by: Sander Vanheule <sander@...nheule.net>

Thanks!

Best,
Sander