linux-kernel - Re: [PATCH net] bnxt_en: bring back rtnl lock in bnxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTV5gtpfM7CXP_s506YDGC8NbSLNmwPJ_FvY_k4Ej1cojw@mail.gmail.com>
Date: Sat, 29 Mar 2025 19:25:22 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org, 
	michael.chan@...adcom.com, pavan.chebbi@...adcom.com, andrew+netdev@...n.ch
Subject: Re: [PATCH net] bnxt_en: bring back rtnl lock in bnxt_shutdown

On Sat, Mar 29, 2025 at 2:42 AM Stanislav Fomichev <sdf@...ichev.me> wrote:
>

Hi Stanislav,
Thanks a lot for this fix!

> Taehee reports missing rtnl from bnxt_shutdown path:
>
> inetdev_event (./include/linux/inetdevice.h:256 net/ipv4/devinet.c:1585)
> notifier_call_chain (kernel/notifier.c:85)
> __dev_close_many (net/core/dev.c:1732 (discriminator 3))
> kernel/locking/mutex.c:713 kernel/locking/mutex.c:732)
> dev_close_many (net/core/dev.c:1786)
> netif_close (./include/linux/list.h:124 ./include/linux/list.h:215
> bnxt_shutdown (drivers/net/ethernet/broadcom/bnxt/bnxt.c:16707) bnxt_en
> pci_device_shutdown (drivers/pci/pci-driver.c:511)
> device_shutdown (drivers/base/core.c:4820)
> kernel_restart (kernel/reboot.c:271 kernel/reboot.c:285)
>
> Bring back the rtnl lock.

Tested-by: Taehee Yoo <ap420073@...il.com>

>
> Link: https://lore.kernel.org/netdev/CAMArcTV4P8PFsc6O2tSgzRno050DzafgqkLA2b7t=Fv_SY=brw@mail.gmail.com/
> Fixes: 004b5008016a ("eth: bnxt: remove most dependencies on RTNL")
> Reported-by: Taehee Yoo <ap420073@...il.com>
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 934ba9425857..1a70605fad38 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -16698,6 +16698,7 @@ static void bnxt_shutdown(struct pci_dev *pdev)
>         if (!dev)
>                 return;
>
> +       rtnl_lock();
>         netdev_lock(dev);
>         bp = netdev_priv(dev);
>         if (!bp)
> @@ -16717,6 +16718,7 @@ static void bnxt_shutdown(struct pci_dev *pdev)
>
>  shutdown_exit:
>         netdev_unlock(dev);
> +       rtnl_unlock();
>  }
>
>  #ifdef CONFIG_PM_SLEEP
> --
> 2.48.1
>