linux-kernel - Re: [PATCH v2 1/3] dt-bindings: i3c: Add Qualcomm I3C master controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04945ad2-1372-4c73-beae-fc6449fb9a76@kernel.org>
Date: Sat, 29 Mar 2025 12:06:34 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>,
 alexandre.belloni@...tlin.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, jarkko.nikula@...ux.intel.com,
 linux-i3c@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: andersson@...nel.org, konradybcio@...nel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: i3c: Add Qualcomm I3C master
 controller

On 29/03/2025 10:08, Mukesh Kumar Savaliya wrote:
>>>>> +  I3C in master mode supports up to 12.5MHz, SDR mode data transfer in mixed
>>>>> +  bus mode (I2C and I3C target devices on same i3c bus). It also supports
>>>>> +  hotjoin, IBI mechanism.
>>>>> +
>>>>> +  I3C Controller nodes must be child of GENI based Qualcomm Universal
>>>>> +  Peripharal. Please refer GENI based QUP wrapper controller node bindings
>>>>> +  described in Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml.
>>>>> +
>>>>> +allOf:
>>>>> +  - $ref: i3c.yaml#
>>>>> +
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    const: qcom,i3c-master
>>>>
>>>> And this got worse. It makes also no sense either: how can you claim
>>>> that this covers all possible future I3C masters from Qualcomm?
>>>>
>>>> What was the resolution of previous discussion?
>>>>
>>> Below was my understanding and reply.
>>> "
>>> I think i should remove const. kept it for now as no other compatible to
>>> be added as of now.
>>> let me remove const.
>>> SoC name is not required, as this compatible is generic to all the SOCs.
>>
>> I don't see any talks about const, what are you referring to?
>>
> +properties:
> +  compatible:
> +    : qcom,i3c-geni
> will this be fine ?

Yes, I think that was also suggested by Rob. Or rather follow existing
style so qcom,geni-i3c for the compatible and filename.


Best regards,
Krzysztof