linux-kernel - Re: [PATCH v5 1/1] events/core: fix failure case for accounting child_total_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <GV1PR08MB10521F51BE098C4711407B5C7FBA32@GV1PR08MB10521.eurprd08.prod.outlook.com>
Date: Sat, 29 Mar 2025 11:31:01 +0000
From: Yeo Reum Yun <YeoReum.Yun@....com>
To: Leo Yan <Leo.Yan@....com>
CC: "peterz@...radead.org" <peterz@...radead.org>, "mingo@...hat.com"
	<mingo@...hat.com>, "mingo@...nel.org" <mingo@...nel.org>, "acme@...nel.org"
	<acme@...nel.org>, "namhyung@...nel.org" <namhyung@...nel.org>, Mark Rutland
	<Mark.Rutland@....com>, "alexander.shishkin@...ux.intel.com"
	<alexander.shishkin@...ux.intel.com>, "jolsa@...nel.org" <jolsa@...nel.org>,
	"irogers@...gle.com" <irogers@...gle.com>, "adrian.hunter@...el.com"
	<adrian.hunter@...el.com>, "kan.liang@...ux.intel.com"
	<kan.liang@...ux.intel.com>, "elver@...gle.com" <elver@...gle.com>,
	"james.clark@...aro.org" <james.clark@...aro.org>, Suzuki Poulose
	<Suzuki.Poulose@....com>, Mike Leach <Mike.Leach@....com>,
	"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, nd
	<nd@....com>
Subject: Re: [PATCH v5 1/1] events/core: fix failure case for accounting
 child_total_enable_time at task exit

Hi @Peter and @Ingo.

Could you apply this simple bug fix unless there's no problem please?

Thanks.

________________________________________
From: Leo Yan <leo.yan@....com>
Sent: 27 March 2025 11:03
To: Yeo Reum Yun
Cc: peterz@...radead.org; mingo@...hat.com; mingo@...nel.org; acme@...nel.org; namhyung@...nel.org; Mark Rutland; alexander.shishkin@...ux.intel.com; jolsa@...nel.org; irogers@...gle.com; adrian.hunter@...el.com; kan.liang@...ux.intel.com; elver@...gle.com; james.clark@...aro.org; Suzuki Poulose; Mike Leach; linux-perf-users@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/1] events/core: fix failure case for accounting child_total_enable_time at task exit

On Wed, Mar 26, 2025 at 08:20:03AM +0000, Yeoreum Yun wrote:

[...]

> After this patch, this problem is gone like:
>
> sudo ./perf stat -vvv -e armv8_pmuv3_0/event=0x08/ -e armv8_pmuv3_1/event=0x08/ -- stress-ng --pthread=2 -t 10s
> ...
> armv8_pmuv3_0/event=0x08/: 15396770398 32157963940 21898169000
> armv8_pmuv3_1/event=0x08/: 22428964974 32157963940 10259794940
>
>  Performance counter stats for 'stress-ng --pthread=2 -t 10s':
>
>     15,396,770,398      armv8_pmuv3_0/event=0x08/                                               (68.10%)
>     22,428,964,974      armv8_pmuv3_1/event=0x08/                                               (31.90%)
>
> Signed-off-by: Yeoreum Yun <yeoreum.yun@....com>
> Suggested-by: Peter Zijlstra <peterz@...radead.org>
> Fixes: ef54c1a476aef ("perf: Rework perf_event_exit_event()")

Tested-by: Leo Yan <leo.yan@....com>