linux-kernel - Re: [PATCH v4 3/5] thermal: renesas: rzg3e: Add thermal driver for the Renesas RZ/G3E SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <207f5f63-39b2-4801-ab98-8fd8cb7c1302@web.de>
Date: Sat, 29 Mar 2025 14:01:49 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: John Madieu <john.madieu.xa@...renesas.com>,
 linux-renesas-soc@...r.kernel.org, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>
Cc: John Madieu <john.madieu@...il.com>, LKML <linux-kernel@...r.kernel.org>,
 Biju Das <biju.das.jz@...renesas.com>, Lukasz Luba <lukasz.luba@....com>,
 Magnus Damm <magnus.damm@...il.com>, Stephen Boyd <sboyd@...nel.org>,
 Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH v4 3/5] thermal: renesas: rzg3e: Add thermal driver for
 the Renesas RZ/G3E SoC

…
> +++ b/drivers/thermal/renesas/rzg3e_thermal.c
> @@ -0,0 +1,445 @@
…
> +static irqreturn_t rzg3e_thermal_adc_irq(int irq, void *dev_id)
> +{
…
> +	int new_temp = temp_val * MILLIDEGREE_PER_DEGREE;
> +
> +	scoped_guard(spinlock_irqsave, &priv->reg_lock) {
> +		priv->cached_temp = new_temp;
> +	}
> +
> +	complete(&priv->conv_complete);
…

Are curly brackets really relevant for such a “scoped guard”?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.14#n197

Regards,
Markus