linux-kernel - Re: [PATCH 2/4] tracing: tprobe-events: Support multiple tprobes on the same tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250329223535.e121322ab3191368ad5ee799@kernel.org>
Date: Sat, 29 Mar 2025 22:35:35 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Masami Hiramatsu (Google) <mhiramat@...nel.org>
Cc: Steven Rostedt <rostedt@...dmis.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] tracing: tprobe-events: Support multiple tprobes on
 the same tracepoint

On Wed, 26 Mar 2025 07:08:09 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> > > +	/* tpoint can be NULL, but we don't care here. */
> > > +
> > > +	/* Search existing tracepoint_user */
> > > +	for_each_trace_fprobe(tf, dpos) {
> > > +		if (!trace_fprobe_is_tracepoint(tf))
> > > +			continue;
> > > +		if (!strcmp(tf->symbol, name)) {
> > 
> > If the try_module_get() failed, can this every be true?
> 
> Ah, that becomes true in the next patch. In this patch, it should
> not be true.

No, I was wrong. Even if the try_module_get() failed, tracepoint_user
is allocated anyway (with tpoint = NULL). Thus this can be true.

Thank you,

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>