linux-kernel - Re: [PATCH v2] media: i2c: Add OV05C10 camera sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fef11ce6-b3b6-4677-9387-13332b9a9d43@linaro.org>
Date: Sat, 29 Mar 2025 01:18:39 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Pratap Nirujogi <pratap.nirujogi@....com>, mchehab@...nel.org,
 sakari.ailus@...ux.intel.com, hverkuil@...all.nl,
 laurent.pinchart@...asonboard.com, dave.stevenson@...pberrypi.com,
 krzk@...nel.org, dan.carpenter@...aro.org
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 benjamin.chan@....com, bin.du@....com, grosikop@....com, king.li@....com,
 dantony@....com, Venkata Narendra Kumar Gutta <vengutta@....com>
Subject: Re: [PATCH v2] media: i2c: Add OV05C10 camera sensor driver

On 28/03/2025 21:42, Pratap Nirujogi wrote:
> From: Bin Du <Bin.Du@....com>

> +static const struct i2c_device_id ov05c10_id[] = {
> +	{"ov05c10", 0 },
> +	{ }
> +};

There's an IPU6/IPU7 version of this driver.

https://github.com/intel/ipu6-drivers/blob/master/drivers/media/i2c/ov05c10.c

Perhaps you could import the Intel ACPI name contained in there too.

> +
> +MODULE_DEVICE_TABLE(i2c, ov05c10_id);
> +
> +static struct i2c_driver ov05c10_i2c_driver = {
> +	.driver = {
> +		.name = DRV_NAME,
> +		.pm = pm_ptr(&ov05c10_pm_ops),
> +	},
> +	.id_table = ov05c10_id,
> +	.probe = ov05c10_probe,
> +	.remove = ov05c10_remove,
> +};
> +
> +module_i2c_driver(ov05c10_i2c_driver);
> +
> +MODULE_AUTHOR("Pratap Nirujogi <pratap.nirujogi@....com>");
> +MODULE_AUTHOR("Venkata Narendra Kumar Gutta <vengutta@....com>");
> +MODULE_AUTHOR("Bin Du <bin.du@....com>");
> +MODULE_DESCRIPTION("OmniVision OV05C1010 sensor driver");
> +MODULE_LICENSE("GPL v2");

Why v2 ? Checkpatch will complain about v2 and BTW the IPU6 driver above 
is GPL not GPL v2.

---
bod