linux-kernel - [PATCH v2 3/9] media: i2c: imx334: Remove redundant register entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250329054335.19931-4-tarang.raval@siliconsignals.io>
Date: Sat, 29 Mar 2025 11:13:25 +0530
From: Tarang Raval <tarang.raval@...iconsignals.io>
To: sakari.ailus@...ux.intel.com,
	kieran.bingham@...asonboard.com
Cc: Shravan.Chippa@...rochip.com,
	Tarang Raval <tarang.raval@...iconsignals.io>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Hans Verkuil <hverkuil@...all.nl>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Zhi Mao <zhi.mao@...iatek.com>,
	Julien Massot <julien.massot@...labora.com>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Luis Garcia <git@...gi311.com>,
	Mikhail Rudenko <mike.rudenko@...il.com>,
	linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH v2 3/9] media: i2c: imx334: Remove redundant register entries

IMX334_REG_{ADBIT, MDBIT, ADBIT1}: Already written in
imx334_set_framefmt function.

IMX334_REG_THSPREPARE: Unnecessary repeated writes removed.

CCI_REG8(0x3e04): Unnecessary repeated writes removed.

Signed-off-by: Tarang Raval <tarang.raval@...iconsignals.io>
---
 drivers/media/i2c/imx334.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index 0785bf213d91..9d4d15df8dcf 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -226,7 +226,6 @@ static const struct cci_reg_sequence common_mode_regs[] = {
 	{ IMX334_REG_OPB_SIZE_V,	0x00 },
 	{ IMX334_REG_HREVERSE,		0x00 },
 	{ IMX334_REG_VREVERSE,		0x00 },
-	{ IMX334_REG_ADBIT,		0x00 },
 	{ IMX334_REG_UNREAD_PARAM5,	0x0000 },
 	{ IMX334_REG_UNREAD_PARAM6,	0x0008 },
 	{ IMX334_REG_XVS_XHS_OUTSEL,	0x20 },
@@ -239,19 +238,13 @@ static const struct cci_reg_sequence common_mode_regs[] = {
 	{ IMX334_REG_INCKSEL4,		0x7e },
 	{ IMX334_REG_SYS_MODE,		0x02 },
 	{ IMX334_REG_HADD_VADD,		0x00 },
-	{ IMX334_REG_MDBIT,		0x00 },
 	{ IMX334_REG_VALID_EXPAND,	0x03 },
 	{ IMX334_REG_TCYCLE,		0x00 },
-	{ IMX334_REG_ADBIT1,		0x01ff },
 	{ IMX334_REG_LANEMODE,		0x03 },
 	{ IMX334_REG_TCLKPOST,		0x007f },
 	{ IMX334_REG_TCLKPREPARE,	0x0037 },
 	{ IMX334_REG_TCLKTRAIL,		0x0037 },
 	{ IMX334_REG_TCLKZERO,		0xf7 },
-	{ IMX334_REG_THSPREPARE,	0x003f },
-	{ IMX334_REG_THSPREPARE,	0x006f },
-	{ IMX334_REG_THSPREPARE,	0x003f },
-	{ IMX334_REG_THSPREPARE,	0x005f },
 	{ IMX334_REG_THSPREPARE,	0x002f },
 	{ CCI_REG8(0x3078), 0x02 },
 	{ CCI_REG8(0x3079), 0x00 },
@@ -339,7 +332,6 @@ static const struct cci_reg_sequence common_mode_regs[] = {
 	{ CCI_REG8(0x37b0), 0x37 },
 	{ CCI_REG8(0x3e04), 0x0e },
 	{ IMX334_REG_AGAIN, 0x0050 },
-	{ CCI_REG8(0x3e04), 0x0e },
 	{ IMX334_REG_MASTER_MODE, 0x00 },
 };
 
-- 
2.34.1