linux-kernel - Re: [PATCH v3 0/2] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174329418093.2439779.7622824447479032708.robh@kernel.org>
Date: Sat, 29 Mar 2025 19:27:01 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Christopher Obbard <christopher.obbard@...aro.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, 
 Douglas Anderson <dianders@...omium.org>, 
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
 Abel Vesa <abel.vesa@...aro.org>, Rui Miguel Silva <rui.silva@...aro.org>, 
 Thomas Zimmermann <tzimmermann@...e.de>, Maxime Ripard <mripard@...nel.org>, 
 Simona Vetter <simona@...ll.ch>, 
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
 linux-arm-msm@...r.kernel.org, David Airlie <airlied@...il.com>, 
 Neil Armstrong <neil.armstrong@...aro.org>, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Jessica Zhang <quic_jesszhan@...cinc.com>, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Johan Hovold <johan@...nel.org>, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v3 0/2] Add support for OLED panel used on Snapdragon
 Lenovo T14s Gen6


On Thu, 27 Mar 2025 16:56:52 +0000, Christopher Obbard wrote:
> The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
> panels. This patch series adds support for the OLED model which has a
> Samsung ATNA40YK20 panel.
> 
> With this patch series, the backlight of the OLED eDP panel does not
> illuminate since the brightness is incorrectly read from the eDP panel
> as 0 (to be clear this is not a regression). This will be fixed in a
> follow-up patch series as it does not block the device tree patches.
> 
> Signed-off-by: Christopher Obbard <christopher.obbard@...aro.org>
> ---
> Changes in v3:
> - Added review trailers from v2.
> - Dropped dt-binding documentation patch (applied by Douglas Anderson into
>   drm-misc-next).
> - Dropped eDP maximum brightness patch (will be sent in separate
>   series).
> - Removed duplicate nodes in T14s OLED device tree.
> - Reworked WIP comments from commit messages.
> - Link to v2: https://lore.kernel.org/r/20250325-wip-obbardc-qcom-t14s-oled-panel-v2-0-e9bc7c9d30cc@linaro.org
> 
> Changes in v2:
> - Use the existing atna33xc20 driver rather than panel-edp.
> - Add eDP panel into OLED devicetree.
> - Add patch to read the correct maximum brightness from the eDP panel.
> - Link to v1: https://lore.kernel.org/r/20250320-wip-obbardc-qcom-t14s-oled-panel-v1-1-05bc4bdcd82a@linaro.org
> 
> ---
> Christopher Obbard (2):
>       arm64: dts: qcom: x1e78100-t14s: add hpd gpio to eDP panel
>       arm64: dts: qcom: x1e78100-t14s-oled: add eDP panel
> 
>  .../boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts      |  8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi   | 11 +++++++++++
>  2 files changed, 19 insertions(+)
> ---
> base-commit: b6ae34803e82511009e2b78dc4fd154330ecdc2d
> change-id: 20250320-wip-obbardc-qcom-t14s-oled-panel-b74fed21d600
> 
> Best regards,
> --
> Christopher Obbard <christopher.obbard@...aro.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit b6ae34803e82511009e2b78dc4fd154330ecdc2d

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250327-wip-obbardc-qcom-t14s-oled-panel-v3-0-45d5f2747398@...aro.org:

arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dtb: panel: compatible: 'oneOf' conditional failed, one must be fixed:
	['samsung,atna40yk20', 'samsung,atna33xc20'] is too long
	'samsung,atna33xc20' was expected
	'samsung,atna40yk20' is not one of ['samsung,atna45af01', 'samsung,atna45dc02', 'samsung,atna56ac03']
	from schema $id: http://devicetree.org/schemas/display/panel/samsung,atna33xc20.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dtb: /soc@...isplay-subsystem@...0000/displayport-controller@...0000/aux-bus/panel: failed to match any schema with compatible: ['samsung,atna40yk20', 'samsung,atna33xc20']