linux-kernel - Re: [PATCH 6.1&6.6 V3 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAASaF6zvEntqKZUzqRjw4Pp5edsRHdd0Dz7-RD=TTMc1n_HMPA@mail.gmail.com>
Date: Sun, 30 Mar 2025 15:40:23 +0200
From: Jan Stancek <jstancek@...hat.com>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Huacai Chen <chenhuacai@...ngson.cn>, 
	Sasha Levin <sashal@...nel.org>, Xuerui Wang <kernel@...0n.name>, stable@...r.kernel.org, 
	David Howells <dhowells@...hat.com>, David Woodhouse <dwmw2@...radead.org>, 
	Jarkko Sakkinen <jarkko@...nel.org>, keyrings@...r.kernel.org, linux-kernel@...r.kernel.org, 
	loongarch@...ts.linux.dev, R Nageswara Sastry <rnsastry@...ux.ibm.com>, 
	Neal Gompa <neal@...pa.dev>
Subject: Re: [PATCH 6.1&6.6 V3 3/3] sign-file,extract-cert: use pkcs11
 provider for OPENSSL MAJOR >= 3

On Sun, Mar 30, 2025 at 3:08 PM Huacai Chen <chenhuacai@...nel.org> wrote:
>
> On Thu, Mar 20, 2025 at 12:53 AM Jan Stancek <jstancek@...hat.com> wrote:
> >
> > On Wed, Mar 19, 2025 at 5:26 PM Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > >
> > > On Wed, Mar 19, 2025 at 03:44:19PM +0100, Jan Stancek wrote:
> > > > On Wed, Mar 19, 2025 at 07:13:13AM -0700, Greg Kroah-Hartman wrote:
> > > > > On Wed, Mar 19, 2025 at 02:40:31PM +0800, Huacai Chen wrote:
> > > > > > From: Jan Stancek <jstancek@...hat.com>
> > > > > >
> > > > > > commit 558bdc45dfb2669e1741384a0c80be9c82fa052c upstream.
> > > > > >
> > > > > > ENGINE API has been deprecated since OpenSSL version 3.0 [1].
> > > > > > Distros have started dropping support from headers and in future
> > > > > > it will likely disappear also from library.
> > > > > >
> > > > > > It has been superseded by the PROVIDER API, so use it instead
> > > > > > for OPENSSL MAJOR >= 3.
> > > > > >
> > > > > > [1] https://github.com/openssl/openssl/blob/master/README-ENGINES.md
> > > > > >
> > > > > > [jarkko: fixed up alignment issues reported by checkpatch.pl --strict]
> > > > > >
> > > > > > Signed-off-by: Jan Stancek <jstancek@...hat.com>
> > > > > > Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> > > > > > Tested-by: R Nageswara Sastry <rnsastry@...ux.ibm.com>
> > > > > > Reviewed-by: Neal Gompa <neal@...pa.dev>
> > > > > > Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
> > > > > > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> > > > > > ---
> > > > > >  certs/extract-cert.c | 103 ++++++++++++++++++++++++++++++-------------
> > > > > >  scripts/sign-file.c  |  93 ++++++++++++++++++++++++++------------
> > > > > >  2 files changed, 138 insertions(+), 58 deletions(-)
> > > > >
> > > > > This seems to differ from what is upstream by a lot, please document
> > > > > what you changed from it and why when you resend this series again.
> > > >
> > > > Hunks are arranged differently, but code appears to be identical.
> > > > When I apply the series to v6.6.83 and compare with upstream I get:
> > >
> > > If so, why is the diffstat different?  Also why are the hunks arranged
> > > differently,
> >
> > He appears to be using "--diff-algorithm=minimal", while you probably
> > patience or histogram.
> Hi, Jan,
>
> I tried --diff-algorithm=minimal/patience/histogram from the upstream
> commit, they all give the same result as this patch. But Sasha said
> the upstream diffstat is different, so how does he generate the patch?

Hi,

I don't know how he generates the patch, but with git-2.43 I get noticable
different patches and diff stats for minimal vs. histogram. "minimal" one
matches your v3 patch. I don't know details of Greg's workflow, just offered
one possible explanation that would allow this series to progress further.

$ git format-patch -1 --stdout --diff-algorithm=minimal 558bdc45dfb2 |
grep -A3 -m1 -- "---"
---
 certs/extract-cert.c | 103 ++++++++++++++++++++++++++++++-------------
 scripts/sign-file.c  |  93 ++++++++++++++++++++++++++------------
 2 files changed, 138 insertions(+), 58 deletions(-)

$ git format-patch -1 --stdout --diff-algorithm=histogram 558bdc45dfb2
| grep -A3 -m1 -- "---"
---
 certs/extract-cert.c | 103 ++++++++++++++++++++++++++++++-------------
 scripts/sign-file.c  |  95 +++++++++++++++++++++++++++------------
 2 files changed, 139 insertions(+), 59 deletions(-)

Regards,
Jan

>
> Huacai
>
> >
> > $ git format-patch -1 --stdout --diff-algorithm=minimal 558bdc45dfb2 |
> > grep -A3 -m1 -- "---"
> > ---
> >  certs/extract-cert.c | 103 ++++++++++++++++++++++++++++++-------------
> >  scripts/sign-file.c  |  93 ++++++++++++++++++++++++++------------
> >  2 files changed, 138 insertions(+), 58 deletions(-)
> >
> > Should be easy to regenerate with different diff-alg for v4.
> >
> > Regards,
> > Jan
> >
> > > that's a hint to me that something went wrong and I can't
> > > trust the patch at all.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
>