linux-kernel - Re: [PATCH 4/5] dt-bindings: iio: adc: add ad7405

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250330164041.2afe195f@jic23-huawei>
Date: Sun, 30 Mar 2025 16:40:41 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Nuno Sa
 <nuno.sa@...log.com>, Olivier Moysan <olivier.moysan@...s.st.com>, David
 Lechner <dlechner@...libre.com>, Javier Carrasco
 <javier.carrasco.cruz@...il.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Trevor Gamblin
 <tgamblin@...libre.com>, Guillaume Stols <gstols@...libre.com>, Dumitru
 Ceclan <mitrutzceclan@...il.com>, Matteo Martelli
 <matteomartelli3@...il.com>, Marcelo Schmitt <marcelo.schmitt@...log.com>,
 Alisa-Dariana Roman <alisadariana@...il.com>, Ramona Alexandra Nechita
 <ramona.nechita@...log.com>, Thomas Bonnefille
 <thomas.bonnefille@...tlin.com>, Dragos Bogdan <dragos.bogdan@...log.com>,
 <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] dt-bindings: iio: adc: add ad7405

On Mon, 24 Mar 2025 11:07:59 +0200
Pop Ioan Daniel <pop.ioan-daniel@...log.com> wrote:

> Add devicetree bindings for ad7405/adum770x family.
> 
> Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
Hi Pop,

One more trivial thing inline.
> ---
>  .../bindings/iio/adc/adi,ad7405.yaml          | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml
> new file mode 100644
> index 000000000000..e312fa0cdb05
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2025 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad7405.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    adc {
> +       #address-cells = <1>;

Odd alignment going on here. 1 more space I think.

> +        #size-cells = <0>;
> +        compatible = "adi,ad7405";
> +        clocks = <&axi_clk_gen 0>;
> +        vdd1-supply = <&vdd1>;
> +        vdd2-supply = <&vdd2>;
> +        io-backends = <&iio_backend>;
> +    };
> +...
> \ No newline at end of file