linux-kernel - Re: [tip:objtool/urgent 9/23] vmlinux.o: warning: objtool: cdns_mrvl_xspi_setup_clock: unexpected end of section .text.cdns_mrvl_xspi_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rza3hjwh5j4trizohbc4um53mej4nz7ie6adydbepncxjpoqd2@l67idl6i5mmy>
Date: Sat, 29 Mar 2025 19:44:26 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev, 
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org, x86@...nel.org, 
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [tip:objtool/urgent 9/23] vmlinux.o: warning: objtool:
 cdns_mrvl_xspi_setup_clock: unexpected end of section
 .text.cdns_mrvl_xspi_setup_clock

On Sat, Mar 29, 2025 at 01:06:56PM -0700, Nathan Chancellor wrote:
> On Fri, Mar 28, 2025 at 09:46:06PM -0700, Josh Poimboeuf wrote:
> > On Fri, Mar 28, 2025 at 04:24:49PM -0700, Nathan Chancellor wrote:
> > > vmlinux.o: warning: objtool: synaptics_report_mt_data: unexpected end of section .text.synaptics_report_mt_data
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x33e: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x254: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x1d4: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x1b8: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x156: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x13a: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0xda: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0xbe: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x63: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x48: (branch)
> > > vmlinux.o: warning: objtool:   synaptics_report_mt_data+0x0: <=== (sym)
> > > ./tools/objtool/objtool --hacks=jump_label --hacks=noinstr --static-call --uaccess --noinstr --link vmlinux.o.orig -o vmlinux.o
> > 
> > Nice!  Can you share the disassembly of the function?
> 
> Sure thing!
> 
> >   objdump -drw -j .text.synaptics_report_mt_data vmlinux.o.orig
> 
> 0000000000000000 <synaptics_report_mt_data>:

This is KCOV leaving dead code again.  I thought I had silenced those
with

  6b023c784204 ("objtool: Silence more KCOV warnings")

but it looks like I mixed up GCOV_KERNEL with KCOV.

Can you confirm this fixes?

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index b93597420daf..4d543054f723 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -275,7 +275,7 @@ objtool-args-$(CONFIG_MITIGATION_SLS)			+= --sls
 objtool-args-$(CONFIG_STACK_VALIDATION)			+= --stackval
 objtool-args-$(CONFIG_HAVE_STATIC_CALL_INLINE)		+= --static-call
 objtool-args-$(CONFIG_HAVE_UACCESS_VALIDATION)		+= --uaccess
-objtool-args-$(CONFIG_GCOV_KERNEL)			+= --no-unreachable
+objtool-args-$(or $(CONFIG_GCOV_KERNEL),$(CONFIG_KCOV))	+= --no-unreachable
 objtool-args-$(CONFIG_PREFIX_SYMBOLS)			+= --prefix=$(CONFIG_FUNCTION_PADDING_BYTES)
 objtool-args-$(CONFIG_OBJTOOL_WERROR)			+= --Werror