[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7giy3wpm4xyth6ol7wvfg5r446lmmdftw656vwdhbyzs6xrewh@25etguysdhqh>
Date: Sun, 30 Mar 2025 20:49:11 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Yongbang Shi <shiyongbang@...wei.com>
Cc: xinliang.liu@...aro.org, tiantao6@...ilicon.com,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
kong.kongxinwei@...ilicon.com, liangjian010@...wei.com,
chenjianmin@...wei.com, lidongming5@...wei.com, libaihan@...wei.com,
shenjian15@...wei.com, shaojijie@...wei.com,
jani.nikula@...ux.intel.com, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector
info and EDID by using AUX channel
On Thu, Mar 20, 2025 at 06:14:51PM +0800, Yongbang Shi wrote:
> From: Baihan Li <libaihan@...wei.com>
>
> Add registering drm_aux and use it to get connector edid with drm
> functions. Add ddc channel in connector initialization to put drm_aux
> in drm_connector.
>
> Signed-off-by: Baihan Li <libaihan@...wei.com>
> Signed-off-by: Yongbang Shi <shiyongbang@...wei.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
> ChangeLog:
> v7 -> v8:
> - use drm_edid_read() in hibmc_dp_connector_get_modes(), suggested by Jani Nikula
> v6 -> v7:
> - add if statement about drm aux in hibmc_dp_connector_get_modes(), suggested by Jani Nikula
> v5 -> v6:
> - move the detect_ctx() to the patch 7/9.
> v2 -> v3:
> - Capitalized EDID and AUX, suggested by Dmitry Baryshkov.
> v1 -> v2:
> - deleting type conversion, suggested by Dmitry Baryshkov.
> - deleting hibmc_dp_connector_get_modes() and using drm_connector_helper_get_modes(), suggested by Dmitry Baryshkov.
> ---
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 3 +-
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 31 ++++++++++++++++---
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 5 +++
> 3 files changed, 33 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c
> index ded9e7ce887a..e0bb9b14d9d8 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c
> @@ -161,7 +161,8 @@ void hibmc_dp_aux_init(struct hibmc_dp *dp)
> HIBMC_DP_MIN_PULSE_NUM);
>
> dp->aux.transfer = hibmc_dp_aux_xfer;
> - dp->aux.is_remote = 0;
> + dp->aux.name = kasprintf(GFP_KERNEL, "HIBMC DRM dp aux");
As being discussed in the feedback for v7, this is a memory leak. Can
you simply assign the string here?
> + dp->aux.drm_dev = dp->drm_dev;
> drm_dp_aux_init(&dp->aux);
> dp->dp_dev->aux = &dp->aux;
> }
--
With best wishes
Dmitry
Powered by blists - more mailing lists