linux-kernel - Re: [PATCH 3/3] ARM: dts: amlogic: Add TCU Fernsehfee 3.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCD13CNuxRkrSoPXUMNQ9AJH7UV0gsOfdgeRKhkXsANgnw@mail.gmail.com>
Date: Sun, 30 Mar 2025 23:10:28 +0200
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: j.ne@...teo.net
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Jerome Brunet <jbrunet@...libre.com>, Kevin Hilman <khilman@...libre.com>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 3/3] ARM: dts: amlogic: Add TCU Fernsehfee 3.0

Thanks for your patch!

On Sun, Mar 23, 2025 at 1:38 PM J. Neuschäfer via B4 Relay
<devnull+j.ne.posteo.net@...nel.org> wrote:
[...]
> +               eth_phy0: ethernet-phy@0 {
> +                       /* IC Plus IP101A (0x02430c54) */
> +                       reg = <0>;
Does reg = <1> also work on your board?
0 is the broadcast address. It's unfortunately something that we still
have incorrect in a lot of .dts files.

[...]
> +&i2c_AO {
> +       status = "okay";
> +       pinctrl-0 = <&i2c_ao_pins>;
> +       pinctrl-names = "default";
> +
> +       pmic@32 {
> +               compatible = "ricoh,rn5t618";
> +               reg = <0x32>;
> +               system-power-controller;
Here I'm a bit surprised:
Aren't some of the outputs used to drive VCCK (CPU power rail) and
VDDEE (everything else power rail, which also powers the GPU)?

[...]
> +&usb1 {
> +       status = "okay";
> +       dr_mode = "host";
> +       /*
> +        * This bus features a Realtek RTL8188 2.4GHz WiFi module, with a
> +        * 3.3V supply voltage that must be enabled before use.
> +        */
> +       vbus-supply = <&wifi_3v3>;
If you want to go for perfection then you can use
Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml as
reference.
It's also an "onboard" USB device which requires toggling a GPIO and regulators.
The driver side is super easy to manage as it's generic (meaning: it
parses any GPIO and regulator as long as the USB ID is registered):
drivers/usb/misc/onboard_usb_dev.c

That way you can just describe the RTL8188 on the USB bus and assign
it's vd33-supply without having to (ab)use vbus-supply of the USB
controller.

[...]
> +               sdxc_c_pins: sdxc-c {
> +                       mux {
> +                               groups = "sdxc_d0_c", "sdxc_d13_c",
> +                                       "sdxc_clk_c", "sdxc_cmd_c",
> +                                       "sdxc_d47_c";
> +                               function = "sdxc_c";
> +                               bias_pull_up;
This has to be bias-pull-up (dashes instead of underscores).


Best regards,
Martin