linux-kernel - Re: [PATCH v8 1/2] usb: serial: add support for CH348

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <454deee5-5359-4fc8-bdaa-801de90f6257@ixit.cz>
Date: Mon, 31 Mar 2025 00:11:42 +0200
From: David Heidelberg <david@...t.cz>
To: Nicolas Frattaroli <frattaroli.nicolas@...il.com>, clabbe@...libre.com
Cc: gregkh@...uxfoundation.org, johan@...nel.org,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 martin.blumenstingl@...glemail.com
Subject: Re: [PATCH v8 1/2] usb: serial: add support for CH348

If another Tested-by is needed to get this in, I can build kernel w/ 
driver and give it shot too.

Thanks for your work & testing!

On 30/03/2025 03:24, Nicolas Frattaroli wrote:
> On Tue, 4 Feb 2025 13:58:40 +0000 Corentin Labbe wrote:
>> The CH348 is an USB octo port serial adapter.
>> The device multiplexes all 8 ports in the same pair of Bulk endpoints.
>> Since there is no public datasheet, unfortunately it remains some magic
>> values
>>
>> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
>> ---
>>   drivers/usb/serial/Kconfig  |   9 +
>>   drivers/usb/serial/Makefile |   1 +
>>   drivers/usb/serial/ch348.c  | 736 ++++++++++++++++++++++++++++++++++++
>>   3 files changed, 746 insertions(+)
>>   create mode 100644 drivers/usb/serial/ch348.c
>>
> 
> Tested-by: Nicolas Frattaroli <frattaroli.nicolas@...il.com>
> 
> Quickly gave this another test by just connecting two ports of a CH348 device
> together and making sure data arrives unchowdered at the other end when sending
> at full speed with various baud rates. Seems to work about as well as I
> expected my jumper wires to hold up at higher baudrates.
> 
> I'll likely use this to lessen the pile of active USB-to-serial devices on my
> desk while working, so many thanks for keeping up the good work on the driver.
> That way it'll also get some more in-depth real world testing in th e coming
> weeks, but I doubt it needs more testing at this stage.
> 
> Regards,
> Nicolas Frattaroli

-- 
David Heidelberg