linux-kernel - Re: [PATCH v2 1/2] serial: sifive: lock port in startup()/shutdown() callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025033015-blanching-pagan-db09@gregkh>
Date: Sun, 30 Mar 2025 09:30:27 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ryo Takakura <ryotkkr98@...il.com>
Cc: alex@...ti.fr, aou@...s.berkeley.edu, jirislaby@...nel.org,
	john.ogness@...utronix.de, palmer@...belt.com,
	paul.walmsley@...ive.com, pmladek@...e.com,
	samuel.holland@...ive.com, bigeasy@...utronix.de,
	conor.dooley@...rochip.com, u.kleine-koenig@...libre.com,
	lkp@...el.com, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org, linux-serial@...r.kernel.org,
	stable@...r.kernel.org, oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v2 1/2] serial: sifive: lock port in startup()/shutdown()
 callbacks

On Sun, Mar 30, 2025 at 10:16:10AM +0900, Ryo Takakura wrote:
> startup()/shutdown() callbacks access SIFIVE_SERIAL_IE_OFFS.
> The register is also accessed from write() callback.
> 
> If console were printing and startup()/shutdown() callback
> gets called, its access to the register could be overwritten.
> 
> Add port->lock to startup()/shutdown() callbacks to make sure
> their access to SIFIVE_SERIAL_IE_OFFS is synchronized against
> write() callback.
> 
> Signed-off-by: Ryo Takakura <ryotkkr98@...il.com>
> Cc: stable@...r.kernel.org
> ---
> 
> Hi,
> 
> I'm sorry that I wasn't aware of how Cc stable should be done. 
> 
> I added Cc for stable but please tell me if this patch should be
> resent or if there is any that is missing.

Please resend a v3.

thanks,

greg k-h