linux-kernel - Re: [PATCH 1/4] i2c: pasemi: Add registers bits and switch to BIT()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <b647d45f-32e3-4864-8a94-2e0b819fba18@app.fastmail.com>
Date: Sun, 30 Mar 2025 10:50:53 +0200
From: "Sven Peter" <sven@...npeter.dev>
To: "Andy Shevchenko" <andy.shevchenko@...il.com>,
 "Andi Shyti" <andi.shyti@...nel.org>
Cc: "Janne Grunau" <j@...nau.net>, "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
 "Madhavan Srinivasan" <maddy@...ux.ibm.com>,
 "Michael Ellerman" <mpe@...erman.id.au>,
 "Nicholas Piggin" <npiggin@...il.com>,
 "Christophe Leroy" <christophe.leroy@...roup.eu>,
 "Naveen N Rao" <naveen@...nel.org>,
 linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org, "Hector Martin" <marcan@...can.st>
Subject: Re: [PATCH 1/4] i2c: pasemi: Add registers bits and switch to BIT()

On Sat, Mar 22, 2025, at 14:23, Andy Shevchenko wrote:
> Thu, Mar 20, 2025 at 01:23:25AM +0100, Andi Shyti kirjoitti:
>> Hi Sven,
>> 
>> On Sat, Feb 22, 2025 at 01:38:33PM +0000, Sven Peter via B4 Relay wrote:
>> > From: Sven Peter <sven@...npeter.dev>
>> > 
>> > Add the missing register bits to the defines and also switch
>> > those to use the BIT macro which is much more readable than
>> > using hardcoded masks
>> > 
>> > Co-developed-by: Hector Martin <marcan@...can.st>
>> > Signed-off-by: Hector Martin <marcan@...can.st>
>> > Signed-off-by: Sven Peter <sven@...npeter.dev>
>> 
>> Just this patch merged to i2c/i2c-host.
>
> This needs an update as well. The proper header for BIT() et al. is bits.h.
> bitfield.h is for FIELD_*() et al.

Ugh, good catch. Since this commit is already on the way upstream I'll send a fix
(and another one to sort the headers alphabetically while I'm at it anyway).


Thanks,


Sven