linux-kernel - Re: [PATCH] Loongarch: Fix device node refcount leak in fdt_cpu_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H77Y2aCWd678KOABZ+yEkXVZWr2ZLMzLQKKs23EWGPPuw@mail.gmail.com>
Date: Sun, 30 Mar 2025 17:43:47 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Miaoqian Lin <linmq006@...il.com>
Cc: WANG Xuerui <kernel@...0n.name>, Binbin Zhou <zhoubinbin@...ngson.cn>, 
	Hongliang Wang <wanghongliang@...ngson.cn>, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Loongarch: Fix device node refcount leak in fdt_cpu_clk_init

Applied, thanks.

Huacai

On Wed, Mar 19, 2025 at 10:54 AM Miaoqian Lin <linmq006@...il.com> wrote:
>
> Add missing of_node_put() to properly handle the reference count of the
> device node obtained from of_get_cpu_node().
>
> Fixes: 44a01f1f726a ("LoongArch: Parsing CPU-related information from DTS")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
>  arch/loongarch/kernel/env.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/loongarch/kernel/env.c b/arch/loongarch/kernel/env.c
> index 2f1f5b08638f..01aea44cf4b0 100644
> --- a/arch/loongarch/kernel/env.c
> +++ b/arch/loongarch/kernel/env.c
> @@ -68,6 +68,7 @@ static int __init fdt_cpu_clk_init(void)
>                 return -ENODEV;
>
>         clk = of_clk_get(np, 0);
> +       of_node_put(np);
>         if (IS_ERR(clk))
>                 return -ENODEV;
>
> --
> 2.39.5 (Apple Git-154)
>