linux-kernel - Re: [PATCH 3/4] mfd: exynos-lpass: Move exynos_lpass

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2dc6a8d-8843-4c25-9e6c-a8a67bd76367@kernel.org>
Date: Sun, 30 Mar 2025 12:02:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, lee@...nel.org,
 alim.akhtar@...sung.com, s.nawrocki@...sung.com, beomho.seo@...sung.com,
 ideal.song@...sung.com
Cc: linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/4] mfd: exynos-lpass: Move exynos_lpass_remove()

On 29/03/2025 08:45, Christophe JAILLET wrote:
> In order be able to call exynos_lpass_remove() from the error handling
> path of the probe, it first needs to be moved before the probe.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

This change makes no sense on its own. There is no point in moving the
code just for moving the code. That's not the goal.

Squash it.

Best regards,
Krzysztof