linux-kernel - Re: [PATCH v2] backlight: pm8941: Add NULL check in wled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17c07117-36a6-4fab-aca8-a4cd3a67f2b0@web.de>
Date: Mon, 31 Mar 2025 18:48:34 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Henry Martin <bsdhenrymartin@...il.com>, linux-fbdev@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc: LKML <linux-kernel@...r.kernel.org>, Daniel Thompson
 <danielt@...nel.org>, Helge Deller <deller@....de>,
 Jingoo Han <jingoohan1@...il.com>, Lee Jones <lee@...nel.org>
Subject: Re: [PATCH v2] backlight: pm8941: Add NULL check in wled_configure()

> devm_kasprintf() return NULL if memory allocation fails. Currently,

                 call?                               failed?


> wled_configure() does not check for this case, leading to a possible NULL
> pointer dereference.

You may omit the word “possible” in such a change description.
(Would questionable data processing happen in other function implementations?)


> Add NULL check after devm_kasprintf() to prevent this issue.

Do you complete the error/exception handling also with the statement “return -ENOMEM;”?

Regards,
Markus