linux-kernel - RE: [PATCH] smccc: kvm_guest: Align with DISCOVER_IMPL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e670c3778d794d82878d0b4cdd3d11d5@huawei.com>
Date: Mon, 31 Mar 2025 06:54:23 +0000
From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>
To: Oliver Upton <oliver.upton@...ux.dev>, "kvmarm@...ts.linux.dev"
	<kvmarm@...ts.linux.dev>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Mark Rutland <mark.rutland@....com>, "Lorenzo
 Pieralisi" <lpieralisi@...nel.org>, Sudeep Holla <sudeep.holla@....com>,
	Catalin Marinas <catalin.marinas@....com>, Marc Zyngier <maz@...nel.org>
Subject: RE: [PATCH] smccc: kvm_guest: Align with DISCOVER_IMPL_CPUS ABI



> -----Original Message-----
> From: Oliver Upton <oliver.upton@...ux.dev>
> Sent: Thursday, March 27, 2025 4:36 PM
> To: kvmarm@...ts.linux.dev
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> Mark Rutland <mark.rutland@....com>; Lorenzo Pieralisi
> <lpieralisi@...nel.org>; Sudeep Holla <sudeep.holla@....com>; Catalin
> Marinas <catalin.marinas@....com>; Marc Zyngier <maz@...nel.org>;
> Oliver Upton <oliver.upton@...ux.dev>; Shameerali Kolothum Thodi
> <shameerali.kolothum.thodi@...wei.com>
> Subject: [PATCH] smccc: kvm_guest: Align with DISCOVER_IMPL_CPUS ABI
> 
> The ABI of the hypercall requires that R2 and R3 are 0. Explicitly pass
> 0 for these parameters.
> 
> Cc: Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>
> Fixes: 86edf6bdcf05 ("smccc/kvm_guest: Enable errata based on
> implementation CPUs")
> Signed-off-by: Oliver Upton <oliver.upton@...ux.dev>

Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>

Thanks,
Shameer

> ---
>  drivers/firmware/smccc/kvm_guest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/smccc/kvm_guest.c
> b/drivers/firmware/smccc/kvm_guest.c
> index 5767aed25cdc..ac2d3cf8a776 100644
> --- a/drivers/firmware/smccc/kvm_guest.c
> +++ b/drivers/firmware/smccc/kvm_guest.c
> @@ -95,7 +95,7 @@ void  __init kvm_arm_target_impl_cpu_init(void)
> 
>  	for (i = 0; i < max_cpus; i++) {
> 
> 	arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_DISCOVE
> R_IMPL_CPUS_FUNC_ID,
> -				     i, &res);
> +				     i, 0, 0, &res);
>  		if (res.a0 != SMCCC_RET_SUCCESS) {
>  			pr_warn("Discovering target implementation CPUs
> failed\n");
>  			goto mem_free;
> 
> base-commit: 369c0122682c4468a69f2454614eded71c5348f3
> --
> 2.39.5