linux-kernel - Re: [PATCH] radix-tree: add missing cleanup.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a79a9854-5449-4460-ab57-214c51095f10@oracle.com>
Date: Mon, 31 Mar 2025 14:21:50 -0400
From: Sidhartha Kumar <sidhartha.kumar@...cle.com>
To: Daniel Gomez <da.gomez@...nel.org>, Peter Zijlstra
 <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>, Ravi Bangoria <ravi.bangoria@....com>,
        Matthew Wilcox <willy@...radead.org>
Cc: linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, gost.dev@...sung.com,
        Daniel Gomez <da.gomez@...sung.com>
Subject: Re: [PATCH] radix-tree: add missing cleanup.h

On 3/21/25 4:24 PM, Daniel Gomez wrote:
> From: Daniel Gomez <da.gomez@...sung.com>
> 
> Add shared cleanup.h header for radix-tree testing tools.
> 
> Fixes build error found with kdevops [1]:
> 
> cc -I../shared -I. -I../../include -I../../../lib -g -Og -Wall
> -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined   -c -o
> radix-tree.o radix-tree.c
> In file included from ../shared/linux/idr.h:1,
>                   from radix-tree.c:18:
> ../shared/linux/../../../../include/linux/idr.h:18:10: fatal error:
> linux/cleanup.h: No such file or directory
>     18 | #include <linux/cleanup.h>
>        |          ^~~~~~~~~~~~~~~~~
> compilation terminated.
> make: *** [<builtin>: radix-tree.o] Error 1
> 
> [1] https://github.com/linux-kdevops/kdevops
> https://github.com/linux-kdevops/linux-mm-kpd/
> actions/runs/13971648496/job/39114756401
> 

This link seems to be broken.

> Fixes: 6c8b0b835f00 ("perf/core: Simplify perf_pmu_register()")
> 
> Signed-off-by: Daniel Gomez <da.gomez@...sung.com>
> ---
>   tools/testing/shared/linux/cleanup.h | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/shared/linux/cleanup.h b/tools/testing/shared/linux/cleanup.h
> new file mode 100644
> index 0000000000000000000000000000000000000000..6e1691f56e300b498c16647bb4b91d8c8be9c3eb
> --- /dev/null
> +++ b/tools/testing/shared/linux/cleanup.h
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _TEST_CLEANUP_H
> +#define _TEST_CLEANUP_H

are these header guards needed?

> +
> +#include "../../../../include/linux/cleanup.h"
> +
> +#endif /* _TEST_CLEANUP_H */
> 
> ---
> base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c
> change-id: 20250321-fix-radix-tree-build-28e21dd4a64b
> 
> Best regards,

Tested-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>