Message-ID: <87ecyd3s09.fsf@kernel.org>
Date: Mon, 31 Mar 2025 21:43:50 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Boqun Feng" <boqun.feng@...il.com>
Cc: "FUJITA Tomonori" <fujita.tomonori@...il.com>,  <tglx@...utronix.de>,
  <linux-kernel@...r.kernel.org>,  <rust-for-linux@...r.kernel.org>,
  <netdev@...r.kernel.org>,  <andrew@...n.ch>,  <hkallweit1@...il.com>,
  <tmgross@...ch.edu>,  <ojeda@...nel.org>,  <alex.gaynor@...il.com>,
  <gary@...yguo.net>,  <bjorn3_gh@...tonmail.com>,
  <benno.lossin@...ton.me>,  <a.hindborg@...sung.com>,
  <aliceryhl@...gle.com>,  <anna-maria@...utronix.de>,
  <frederic@...nel.org>,  <arnd@...db.de>,  <jstultz@...gle.com>,
  <sboyd@...nel.org>,  <mingo@...hat.com>,  <peterz@...radead.org>,
  <juri.lelli@...hat.com>,  <vincent.guittot@...aro.org>,
  <dietmar.eggemann@....com>,  <rostedt@...dmis.org>,
  <bsegall@...gle.com>,  <mgorman@...e.de>,  <vschneid@...hat.com>,
  <tgunders@...hat.com>,  <me@...enk.dev>,  <david.laight.linux@...il.com>
Subject: Re: [PATCH v11 6/8] MAINTAINERS: rust: Add new sections for
 DELAY/SLEEP and TIMEKEEPING API

"Boqun Feng" <boqun.feng@...il.com> writes:

> On Sat, Mar 22, 2025 at 11:40:21PM +0100, Andreas Hindborg wrote:
>> Hi All,
>>
>> "Boqun Feng" <boqun.feng@...il.com> writes:
>>
>> > On Sat, Mar 22, 2025 at 11:07:03AM +0900, FUJITA Tomonori wrote:
>> >> Thank you all!
>> >>
>> >> On Fri, 21 Mar 2025 14:00:52 -0700
>> >> Boqun Feng <boqun.feng@...il.com> wrote:
>> >>
>> >> > On Fri, Mar 21, 2025 at 09:38:46PM +0100, Thomas Gleixner wrote:
>> >> >> On Fri, Mar 21 2025 at 20:18, Andreas Hindborg wrote:
>> >> >> >> Could you add me as a reviewer in these entries?
>> >> >> >>
>> >> >> >
>> >> >> > I would like to be added as well.
>> >> >>
>> >> >> Please add the relevant core code maintainers (Anna-Maria, Frederic,
>> >> >> John Stultz and myself) as well to the reviewers list, so that this does
>> >> >> not end up with changes going in opposite directions.
>> >> >>
>> >> >
>> >> > Make sense, I assume you want this to go via rust then (althought we
>> >> > would like it to go via your tree if possible ;-))?
>> >>
>> >
>> > Given Andreas is already preparing the pull request of the hrtimer
>> > abstraction to Miguel, and delay, timekeeping and hrtimer are related,
>> > these timekeeping/delay patches should go via Andreas (i.e.
>> > rust/hrtimer-next into rust/rust-next) if Thomas and Miguel are OK with
>> > it. Works for you, Andreas? If so...
>> >
>> >> Once the following review regarding fsleep() is complete, I will submit
>> >> patches #2 through #6 as v12 for rust-next:
>> >>
>> >> https://lore.kernel.org/linux-kernel/20250322.102449.895174336060649075.fujita.tomonori@gmail.com/
>> >>
>> >> The updated MAINTAINERS file will look like the following.
>> >>
>> >> diff --git a/MAINTAINERS b/MAINTAINERS
>> >> index cbf84690c495..858e0b34422f 100644
>> >> --- a/MAINTAINERS
>> >> +++ b/MAINTAINERS
>> >> @@ -10370,6 +10370,18 @@ F:	kernel/time/timer_list.c
>> >>  F:	kernel/time/timer_migration.*
>> >>  F:	tools/testing/selftests/timers/
>> >>
>> >> +DELAY AND SLEEP API [RUST]
>> >> +M:	FUJITA Tomonori <fujita.tomonori@...il.com>
>> >> +R:	Boqun Feng <boqun.feng@...il.com>
>> >> +R:	Andreas Hindborg <a.hindborg@...nel.org>
>> >
>> > ... this "R:" entry would be "M:",
>> >
>> >> +R:	Anna-Maria Behnsen <anna-maria@...utronix.de>
>> >> +R:	Frederic Weisbecker <frederic@...nel.org>
>> >> +R:	Thomas Gleixner <tglx@...utronix.de>
>> >> +L:	rust-for-linux@...r.kernel.org
>> >> +L:	linux-kernel@...r.kernel.org
>> >
>> > +T:	git https://github.com/Rust-for-Linux/linux.git hrtimer-next
>> >
>> >> +S:	Maintained
>> >
>> > I will let Andreas decide whether this is a "Supported" entry ;-)
>> >
>> >> +F:	rust/kernel/time/delay.rs
>> >> +
>> >>  HIGH-SPEED SCC DRIVER FOR AX.25
>> >>  L:	linux-hams@...r.kernel.org
>> >>  S:	Orphan
>> >> @@ -23944,6 +23956,17 @@ F:	kernel/time/timekeeping*
>> >>  F:	kernel/time/time_test.c
>> >>  F:	tools/testing/selftests/timers/
>> >>
>> >> +TIMEKEEPING API [RUST]
>> >
>> > and similar things for this entry as well.
>> >
>> >> +M:	FUJITA Tomonori <fujita.tomonori@...il.com>
>> >> +R:	Boqun Feng <boqun.feng@...il.com>
>> >> +R:	Andreas Hindborg <a.hindborg@...nel.org>
>> >> +R:	John Stultz <jstultz@...gle.com>
>> >> +R:	Thomas Gleixner <tglx@...utronix.de>
>> >
>> > +R:      Stephen Boyd <sboyd@...nel.org>
>> >
>> > ?
>> >
>> >> +L:	rust-for-linux@...r.kernel.org
>> >> +L:	linux-kernel@...r.kernel.org
>> >> +S:	Maintained
>> >> +F:	rust/kernel/time.rs
>> >> +
>> >
>> > Tomo, let's wait for Andreas' rely and decide how to change these
>> > entries. Thanks!
>>
>> My recommendation would be to take all of `rust/kernel/time` under one
>> entry for now. I suggest the following, folding in the hrtimer entry as
>> well:
>>
>> DELAY, SLEEP, TIMEKEEPING, TIMERS [RUST]
>> M:	Andreas Hindborg <a.hindborg@...nel.org>
>
> Given you're the one who would handle the patches, I think this make
> more sense.
>
>> R:	Boqun Feng <boqun.feng@...il.com>
>> R:	FUJITA Tomonori <fujita.tomonori@...il.com>
>
> Tomo, does this look good to you?
>
>> R:	Lyude Paul <lyude@...hat.com>
>> R:	Frederic Weisbecker <frederic@...nel.org>
>> R:	Thomas Gleixner <tglx@...utronix.de>
>> R:	Anna-Maria Behnsen <anna-maria@...utronix.de>
>> R:	John Stultz <jstultz@...gle.com>
>
> We should add:
>
> R:      Stephen Boyd <sboyd@...nel.org>
>
> If Stephen is not against it.

Yes 👍

>
>> L:	rust-for-linux@...r.kernel.org
>> S:	Supported
>> W:	https://rust-for-linux.com
>> B:	https://github.com/Rust-for-Linux/linux/issues
>> T:	git https://github.com/Rust-for-Linux/linux.git rust-timekeeping-next
>> F:	rust/kernel/time.rs
>> F:	rust/kernel/time/
>>
>> If that is acceptable to everyone, it is very likely that I can pick 2-6
>> for v6.16.
>>
>
> You will need to fix something because patch 2-6 removes `Ktime` ;-)

Yea, but `Instant` is almost a direct substitution, right? Anyway, Tomo
can send a new spin and change all the uses of Ktime, or I can do it. It
should be straight forward. Either way is fine with me.


Best regards,
Andreas Hindborg

Powered by blists - more mailing lists