linux-kernel - Re: [PATCH v2] mm: annotate data race in update_hiwater

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qplfqar7kht2cyuqntxgzap6cha7evp4b4kj43a3fa7xhujebn@5pdd5igza3wg>
Date: Mon, 31 Mar 2025 21:08:30 +0100
From: Pedro Falcato <pfalcato@...e.de>
To: Ignacio Encinas <ignacio@...cinas.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org, 
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, "Liam R. Howlett" <Liam.Howlett@...cle.com>, 
	linux-kernel-mentees@...ts.linux.dev, skhan@...uxfoundation.org, linux-kernel@...r.kernel.org, 
	syzbot+419c4b42acc36c420ad3@...kaller.appspotmail.com
Subject: Re: [PATCH v2] mm: annotate data race in update_hiwater_rss

On Mon, Mar 31, 2025 at 09:57:05PM +0200, Ignacio Encinas wrote:
> mm_struct.hiwater_rss can be accessed concurrently without proper
> synchronization as reported by KCSAN.
> 
> This data race is benign as it only affects accounting information.
> Annotate it with data_race() to make KCSAN happy.
> 
> Reported-by: syzbot+419c4b42acc36c420ad3@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/all/67e3390c.050a0220.1ec46.0001.GAE@google.com/
> Suggested-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> Signed-off-by: Ignacio Encinas <ignacio@...cinas.com>

Looks good, thank you for the contribution!
Acked-by: Pedro Falcato <pfalcato@...e.de>

--
Pedro