linux-kernel - Re: [PATCH] radix-tree: add missing cleanup.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bprl56l6zhjdjk4vilgqyiekgajgzbanrnstjyh5dpzw2c5xky@exfsrll3hcpw>
Date: Mon, 31 Mar 2025 22:42:53 +0200
From: Daniel Gomez <da.gomez@...nel.org>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Ravi Bangoria <ravi.bangoria@....com>,
	Matthew Wilcox <willy@...radead.org>, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	gost.dev@...sung.com, Daniel Gomez <da.gomez@...sung.com>,
	Luis Chamberlain <mcgrof@...nel.org>,
	R@...os.smtp.subspace.kernel.org
Subject: Re: [PATCH] radix-tree: add missing cleanup.h

On Mon, Mar 31, 2025 at 02:20:32PM +0100, Liam R. Howlett wrote:
> +Cc Luis, as he added this task to the kdevops build.
> 
> Is this going through fsdevel or linux-mm?  It's not entirely clear to
> me.  I assume fsdevel as akpm isn't in the email header?
> 
> * Daniel Gomez <da.gomez@...nel.org> [250321 16:25]:
> > From: Daniel Gomez <da.gomez@...sung.com>
> > 
> > Add shared cleanup.h header for radix-tree testing tools.
> > 
> > Fixes build error found with kdevops [1]:
> > 
> > cc -I../shared -I. -I../../include -I../../../lib -g -Og -Wall
> > -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined   -c -o
> > radix-tree.o radix-tree.c
> > In file included from ../shared/linux/idr.h:1,
> >                  from radix-tree.c:18:
> > ../shared/linux/../../../../include/linux/idr.h:18:10: fatal error:
> > linux/cleanup.h: No such file or directory
> >    18 | #include <linux/cleanup.h>
> >       |          ^~~~~~~~~~~~~~~~~
> > compilation terminated.
> > make: *** [<builtin>: radix-tree.o] Error 1
> > 
> > [1] https://github.com/linux-kdevops/kdevops
> > https://github.com/linux-kdevops/linux-mm-kpd/
> > actions/runs/13971648496/job/39114756401
> 
> I am quite pleased that you saw and fixed the issue with the kdevops
> running the testing!  Thanks!

To add more context:

As Luis mentioned in the "maple tree / xarray CI ready" thread [1], we still
need the kpd setup to run kdevops on patches posted to the mailing list. While
we wait for that, we are running maple and xarray tests with kdevops on a daily
basis using the latest linux-next tag. That’s how we spotted the issue.

If there’s a more relevant tree than linux-next for this, we can integrate it
as well.

[1] https://lore.kernel.org/kdevops/Z5u6UH2r-co6jS_u@bombadil.infradead.org/

> 
> The URL seems to have expired, so thanks for including the failure.
> 
> Can you please not break the link across lines so they work with a
> mouse click?  I believe this is an acceptable time to run over 80
> characters.

FYI, this is an updated link pointing to a more recent version (next-20250331):

https://github.com/linux-kdevops/linux-mm-kpd/actions/runs/14173886747/job/39703944372

However, I think it's not fully visible outside the kdevops organization. So, it
may be better to remove the link from the commit message.

> 
> > 
> > Fixes: 6c8b0b835f00 ("perf/core: Simplify perf_pmu_register()")
> > 
> > Signed-off-by: Daniel Gomez <da.gomez@...sung.com>
> > ---
> >  tools/testing/shared/linux/cleanup.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/tools/testing/shared/linux/cleanup.h b/tools/testing/shared/linux/cleanup.h
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..6e1691f56e300b498c16647bb4b91d8c8be9c3eb
> > --- /dev/null
> > +++ b/tools/testing/shared/linux/cleanup.h
> > @@ -0,0 +1,7 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _TEST_CLEANUP_H
> > +#define _TEST_CLEANUP_H
> 
> The "../../../../include/linux/cleanup.h" itself has these guards, so
> probably not needed?

They are not the same safeguards. The ones in the other file are
"_LINUX_CLEANUP_H". The solution here uses the same approach as in radix-tree.h.

It's probably safe to remove them here anyway.