linux-kernel - Re: [PATCH v4 2/3] dt-bindings: soc: samsung: exynos-pmu: update reset for gs101

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250331-curvy-daring-urchin-aeafa8@krzk-bin>
Date: Mon, 31 Mar 2025 09:15:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Peter Griffin <peter.griffin@...aro.org>, 
	Tudor Ambarus <tudor.ambarus@...aro.org>, Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com, 
	linux-pm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: soc: samsung: exynos-pmu: update
 reset for gs101

On Fri, Mar 28, 2025 at 03:15:20PM +0000, André Draszik wrote:
> Add the gs101-specific reset node, allow it on gs101, and disallow it
> on !gs101. Similarly, disallow the generic 'syscon-reboot' on gs101, as
> we want the specific one in that case.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> ---
>  .../devicetree/bindings/soc/samsung/exynos-pmu.yaml | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> index 204da6fe458d2d4bfeee1471ebc5c38247477ae2..8c7362cf3eeab11f6bb13a27eb295d5ee6721b71 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> @@ -97,6 +97,12 @@ properties:
>      $ref: /schemas/phy/samsung,dp-video-phy.yaml
>      unevaluatedProperties: false
>  
> +  gs101-reboot:

syscon-reboot

> +    $ref: /schemas/power/reset/google,gs101-reboot.yaml#

... which leads us to the existing node. Just use oneOf:

oneOf:
  - $ref: /schemas/power/reset/syscon-reboot.yaml#
  - $ref: /schemas/power/reset/google,gs101-reboot.yaml#

or actually better:

additionalProperties: true
properties:
  compatible:
    enum:
      - syscon-reboot
      - google,gs101-reboot

Best regards,
Krzysztof