linux-kernel - Re: [RFC PATCH 1/2] zsmalloc: let callers select NUMA node to store the compressed objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67eb148e1f818_7baf294b9@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Date: Mon, 31 Mar 2025 15:17:50 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Nhat Pham <nphamcs@...il.com>, <linux-mm@...ck.org>
CC: <akpm@...ux-foundation.org>, <hannes@...xchg.org>,
	<yosry.ahmed@...ux.dev>, <chengming.zhou@...ux.dev>, <sj@...nel.org>,
	<kernel-team@...a.com>, <linux-kernel@...r.kernel.org>, <gourry@...rry.net>,
	<willy@...radead.org>, <ying.huang@...ux.alibaba.com>,
	<jonathan.cameron@...wei.com>, <dan.j.williams@...el.com>,
	<linux-cxl@...r.kernel.org>, <minchan@...nel.org>, <senozhatsky@...omium.org>
Subject: Re: [RFC PATCH 1/2] zsmalloc: let callers select NUMA node to store
 the compressed objects

Nhat Pham wrote:
> Curerntly, zsmalloc does not specify any memory policy when it allocates
> memory for the compressed objects.
> 
> Let users select the NUMA node for the memory allocation, through the
> zpool-based API. Direct callers (i.e zram) should not observe any
> behavioral change.
> 
> Signed-off-by: Nhat Pham <nphamcs@...il.com>
> ---
>  include/linux/zpool.h |  4 ++--
>  mm/zpool.c            |  8 +++++---
>  mm/zsmalloc.c         | 28 +++++++++++++++++++++-------
>  mm/zswap.c            |  2 +-
>  4 files changed, 29 insertions(+), 13 deletions(-)
> 
> diff --git a/include/linux/zpool.h b/include/linux/zpool.h
> index 52f30e526607..0df8722e13d7 100644
> --- a/include/linux/zpool.h
> +++ b/include/linux/zpool.h
> @@ -22,7 +22,7 @@ const char *zpool_get_type(struct zpool *pool);
>  void zpool_destroy_pool(struct zpool *pool);
>  
>  int zpool_malloc(struct zpool *pool, size_t size, gfp_t gfp,
> -			unsigned long *handle);
> +			unsigned long *handle, int *nid);

I agree with Johannes about the policy knob, so I'll just comment on the
implementation.

Why not just pass a "const int" for @nid, and use "NUMA_NO_NODE" for the
"default" case. alloc_pages_node_noprof() is already prepared for a
NUMA_NO_NODE argument.