linux-kernel - Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57f5abc9-9e3f-4053-8c5d-2d6366d669af@intel.com>
Date: Mon, 31 Mar 2025 15:50:04 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: "Huang, Kai" <kai.huang@...el.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "x86@...nel.org"
	<x86@...nel.org>
CC: "Nikula, Jani" <jani.nikula@...el.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "hpa@...or.com"
	<hpa@...or.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kirill.shutemov@...ux.intel.com"
	<kirill.shutemov@...ux.intel.com>, "rppt@...nel.org" <rppt@...nel.org>,
	"bigeasy@...utronix.de" <bigeasy@...utronix.de>, "jpoimboe@...nel.org"
	<jpoimboe@...nel.org>, "pmladek@...e.com" <pmladek@...e.com>, "xin@...or.com"
	<xin@...or.com>, "Luck, Tony" <tony.luck@...el.com>
Subject: Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

On 3/31/2025 3:43 PM, Huang, Kai wrote:
> On Thu, 2025-03-27 at 23:46 +0000, Mehta, Sohil wrote:
>> Commit feeaf5512947 ("x86: Move sysctls into arch/x86")
> 
> AFAICT the commit hash is wrong.  It should be c305a4e98378.
> 

Yes, sorry about that. I ended up referencing a pre-merge duplicate
commit in my repo.

Thankfully, Ingo fixed it when he applied the patch:
https://web.git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/nmi&id=1a5b15f6b4d18507dc3b2958ca01877cfc8808fd


>> recently moved the sysctl handling of panic_on_unrecovered_nmi and
>> panic_on_io_nmi to x86-specific code. These variables no longer need to
>> be declared in the generic header file.
>>
>> Relocate the variable definitions and declarations closer to where they
>> are used. This makes all the NMI panic options consistent and easier to
>> track.
>>
>> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>
> 
> Reviewed-by: Kai Huang <kai.huang@...el.com>
>