linux-kernel - Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2db0cef00e9ad6061af8256c71d0198b15a5ddc.camel@HansenPartnership.com>
Date: Mon, 31 Mar 2025 18:59:36 -0400
From: James Bottomley <James.Bottomley@...senPartnership.com>
To: Dionna Amalie Glaze <dionnaglaze@...gle.com>
Cc: Jarkko Sakkinen <jarkko@...nel.org>, Stefano Garzarella
 <sgarzare@...hat.com>, linux-kernel@...r.kernel.org, Jason Gunthorpe
 <jgg@...pe.ca>, Dave Hansen <dave.hansen@...ux.intel.com>, Borislav Petkov
 <bp@...en8.de>, linux-integrity@...r.kernel.org, Peter Huewe
 <peterhuewe@....de>,  Ingo Molnar <mingo@...hat.com>,
 linux-coco@...ts.linux.dev, Dov Murik <dovmurik@...ux.ibm.com>, Thomas
 Gleixner <tglx@...utronix.de>, Joerg Roedel <jroedel@...e.de>,
 x86@...nel.org, Tom Lendacky <thomas.lendacky@....com>, Claudio Carvalho
 <cclaudio@...ux.ibm.com>, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

On Mon, 2025-03-31 at 15:23 -0700, Dionna Amalie Glaze wrote:
> On Mon, Mar 31, 2025 at 2:26 PM James Bottomley
> <James.Bottomley@...senpartnership.com> wrote:
> > 
> > On Mon, 2025-03-31 at 13:56 -0700, Dionna Amalie Glaze wrote:
> > [...]
> > > I might be unclear on how I should be testing this, but I do see
> > > /dev/tpm0 and /dev/tpmrm0 when I build with CONFIG_TCG_SVSM=y,
> > > but I don't see the event log in securityfs. What am I missing?
> > 
> > The vtpm driver for EDK2/OVMF I suspect ... without that the UEFI
> > won't lay down and event log for the kernel to pick up.
> 
> This test is with Oliver's PR
> https://github.com/tianocore/edk2/pull/6527

Well, since the event log is searched for in tpm_chip_register(), I
really don't think it can be the kernel driver.  Best guess is there's
something wrong with that patch set (or the vTPM didn't activate in
OVMF for some reason).

Regards,

James