linux-kernel - Re: [PATCH 1/9] x86/nmi: Simplify unknown NMI panic handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65011648-422f-456d-82ca-0421d151290c@intel.com>
Date: Mon, 31 Mar 2025 16:01:01 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: "Huang, Kai" <kai.huang@...el.com>
CC: "Nikula, Jani" <jani.nikula@...el.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "hpa@...or.com"
	<hpa@...or.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kirill.shutemov@...ux.intel.com"
	<kirill.shutemov@...ux.intel.com>, "rppt@...nel.org" <rppt@...nel.org>,
	"bigeasy@...utronix.de" <bigeasy@...utronix.de>, "jpoimboe@...nel.org"
	<jpoimboe@...nel.org>, "pmladek@...e.com" <pmladek@...e.com>, "xin@...or.com"
	<xin@...or.com>, "Luck, Tony" <tony.luck@...el.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "x86@...nel.org"
	<x86@...nel.org>
Subject: Re: [PATCH 1/9] x86/nmi: Simplify unknown NMI panic handling

On 3/31/2025 3:52 PM, Huang, Kai wrote:

>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>> index c7164a8de983..c3e1ae7373e9 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -7,10 +7,11 @@
>>   */
>>  #include <linux/acpi.h>
>>  #include <linux/console.h>
>> -#include <linux/cpu.h>
>>  #include <linux/crash_dump.h>
>> +#include <linux/cpu.h>
> 
> This code change doesn't seem to be able to make the headers in "alphabetical
> order".
> 

Ah! Thanks for catching it.


>>  
>>  #include <asm/apic.h>
>> -#include <asm/efi.h>
> 
> Seems this header just got removed here but was never added back.
> 

<asm/efi.h> is included twice. Therefore, the diff only shows it being
removed.

>> -#include <asm/numa.h>
>>  #include <asm/bios_ebda.h>
>>  #include <asm/bugs.h>
>>  #include <asm/cacheinfo.h>

Thanks,
Sohil