linux-kernel - RE: [PATCH v2] hv/hv_kvp_daemon: Enable debug logs for hv_kvp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL4PR21MB462765E191592754911DB67BBFAD2@BL4PR21MB4627.namprd21.prod.outlook.com>
Date: Mon, 31 Mar 2025 23:20:09 +0000
From: Dexuan Cui <decui@...rosoft.com>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>, KY Srinivasan
	<kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu
	<wei.liu@...nel.org>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Shradha Gupta <shradhagupta@...rosoft.com>
Subject: RE: [PATCH v2] hv/hv_kvp_daemon: Enable debug logs for hv_kvp_daemon

> From: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> Sent: Sunday, March 30, 2025 11:15 PM
> [...]
> +static void convert_tm_to_string(char *tm_str, size_t tm_str_size)
> +{
> +	struct tm tm;
> +	time_t t;
> +
> +	time(&t);
> +	gmtime_r(&t, &tm);
> +	strftime(tm_str, tm_str_size, "%Y-%m-%dT%H:%M:%S", &tm);
> +}

Now the function is unnecessary since v2 uses syslog(), which already prefixes every
message with a timestamp.

> +static void kvp_dump_initial_pools(int pool)
> +{
> +	char tm_str[50];
> +	int i;
> +
> +	convert_tm_to_string(tm_str, sizeof(tm_str));
This is unnecessary now.

> +	syslog(LOG_DEBUG, "===Start dumping the contents of pool %d
> ===\n",
> +	       pool);
> +
> +	for (i = 0; i < kvp_file_info[pool].num_records; i++)
> +		syslog(LOG_DEBUG, "[%s]: pool: %d, %d/%d key=%s
> val=%s\n",
> +		       tm_str, pool, i, kvp_file_info[pool].num_records,

Can you change the 'i' to 'i+1'? This makes the messages a little more natural to
users who are not programmers :-)

>  static int kvp_key_add_or_modify(int pool, const __u8 *key, int key_size,

Can you add a log message for KVP_OP_DELETE as well?

Thanks,
Dexuan