linux-kernel - platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAJw_Zt1cYcg-Fa_rCecwHnWKMi7uO2UGNEhMsxPiQa-pgUMnw@mail.gmail.com>
Date: Mon, 31 Mar 2025 15:51:16 +0800
From: Jeff Chua <jeff.chua.linux@...il.com>
To: lkml <linux-kernel@...r.kernel.org>, Kurt Borja <kuurtb@...il.com>, 
	Mark Pearson <mpearson-lenovo@...ebb.ca>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

This commit prevents the latest linux git from booting. Only those
with thinkpad-acpi will see this.
There's no clean way to revert this. I took the thinkpad_acpi.c from
vanilla 6.14.0 and that booted up with the latest linux git
(4e82c87058f45e79eeaa4d5bcc3b38dd3dce7209).




commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f
Author: Kurt Borja <kuurtb@...il.com>
Date:   Fri Feb 14 19:03:01 2025 -0500

    platform/x86: thinkpad_acpi: Move subdriver initialization to
tpacpi_pdriver's probe.

    It was reported that if subdrivers assigned devres resources inside
    ibm_init_struct's .init callbacks, driver binding would fail with the
    following error message:

            platform thinkpad_acpi: Resources present before probing

    Let the driver core manage the lifetimes of the subdrivers and children
    devices, by initializing them inside tpacpi_driver's .probe callback.
    This is appropriate because these subdrivers usually expose sysfs groups
    and the driver core manages this automatically to avoid races.

    One immediate benefit of this, is that we are now able to use devres
    inside .init subdriver callbacks.

    platform_create_bundle is specifically used because it makes the
    driver's probe type synchronous and returns an ERR_PTR if attachment
    failed.

    Additionally, to make error handling simpler, allocate the input device
    using devm_input_allocate_device().

    Reported-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
    Closes: https://lore.kernel.org/platform-driver-x86/20250208091438.5972-1-mpearson-lenovo@squebb.ca/#t
    Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
    Tested-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
    Signed-off-by: Kurt Borja <kuurtb@...il.com>
    Link: https://lore.kernel.org/r/20250215000302.19753-2-kuurtb@gmail.com
    Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>



My best.,
Jeff