[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0638eb8c-d87f-44aa-9f1c-eee529b1e1a1@linaro.org>
Date: Mon, 31 Mar 2025 09:57:47 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, wim@...ux-watchdog.org
Cc: linux@...ck-us.net, linux-watchdog@...r.kernel.org,
linux-kernel@...r.kernel.org, S32@....com,
Ghennadi Procopciuc <ghennadi.procopciuc@....com>,
Thomas Fossati <thomas.fossati@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add NXP Software Watchdog
Timer
On 29/03/2025 06:04, Krzysztof Kozlowski wrote:
> On 28/03/2025 16:15, Daniel Lezcano wrote:
>> +description:
>> + The System Timer Module supports commonly required system and
>> + application software timing functions. STM includes a 32-bit
>> + count-up timer and four 32-bit compare channels with a separate
>> + interrupt source for each channel. The timer is driven by the STM
>> +
>> +allOf:
>> + - $ref: watchdog.yaml#
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - nxp,s32g-wdt
> This wasn't tested, so limited review - this also has wrong compatible,
> There is no such soc as s32g in the kernel. If that's a new soc, come
> with proper top-level bindings and some explanation, because I am sure
> previously we talked with NXP that this is not s32g but something else.
If I refer to Documentation/devicetree/bindings/arm/fsl.yaml
We found the entries:
- description: S32G2 based Boards
items:
- enum:
- nxp,s32g274a-evb
- nxp,s32g274a-rdb2
- const: nxp,s32g2
- description: S32G3 based Boards
items:
- enum:
- nxp,s32g399a-rdb3
- const: nxp,s32g3
I guess it should nxp,s32g2-wdt and nxp,s32g3-wdt
Right ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists