linux-kernel - Re: [PATCH v3 2/2] serial: sifive: Switch to nbcon console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250331080318.BdZQodhu@linutronix.de>
Date: Mon, 31 Mar 2025 10:03:18 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Ryo Takakura <ryotkkr98@...il.com>
Cc: alex@...ti.fr, aou@...s.berkeley.edu, gregkh@...uxfoundation.org,
	jirislaby@...nel.org, john.ogness@...utronix.de, palmer@...belt.com,
	paul.walmsley@...ive.com, pmladek@...e.com,
	samuel.holland@...ive.com, conor.dooley@...rochip.com,
	u.kleine-koenig@...libre.com, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v3 2/2] serial: sifive: Switch to nbcon console

On 2025-03-30 20:21:09 [+0900], Ryo Takakura wrote:
> --- a/drivers/tty/serial/sifive.c
> +++ b/drivers/tty/serial/sifive.c
> @@ -785,33 +786,88 @@ static void sifive_serial_console_putchar(struct uart_port *port, unsigned char
>  
>  	__ssp_wait_for_xmitr(ssp);
>  	__ssp_transmit_char(ssp, ch);
> +
> +	ssp->console_line_ended = (ch == '\n');
> +}
> +
> +static void sifive_serial_device_lock(struct console *co, unsigned long *flags)
> +{
> +	struct uart_port *up = &sifive_serial_console_ports[co->index]->port;
> +
> +	return __uart_port_lock_irqsave(up, flags);

this does look odd. A return statement in a return-void function. The
imx driver started it…

> +}
> +
> +static void sifive_serial_device_unlock(struct console *co, unsigned long flags)
> +{
> +	struct uart_port *up = &sifive_serial_console_ports[co->index]->port;
> +
> +	return __uart_port_unlock_irqrestore(up, flags);
>  }

Sebastian