linux-kernel - Re: [PATCH] media: si2168: increase cmd execution timeout value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-pTmaRpf_FUAlkk@shikoro>
Date: Mon, 31 Mar 2025 10:34:33 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Christian Hewitt <christianshewitt@...il.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Peter Rosin <peda@...ntia.se>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Heiner Kallweit <hkallweit1@...il.com>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: si2168: increase cmd execution timeout value

On Mon, Mar 31, 2025 at 12:31:48PM +0400, Christian Hewitt wrote:
> > On 31 Mar 2025, at 12:06 pm, Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:
> > 
> > 
> >> if (cmd->rlen) {
> >> /* wait cmd execution terminate */
> >> - #define TIMEOUT 70
> >> + #define TIMEOUT 200
> > 
> > While we are here, can we rename it to CMD_TIMEOUT and put it next to
> > the #includes?
> 
> I’m at the novice end of kernel contributors, so like this?

Exactly! Thank you. If you send v2 of this patch, you can already add:

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)