linux-kernel - Re: [PATCH v7] arm64: kprobe: Enable OPTPROBE for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a096fa2-4b3b-931d-453c-ad709e9ba687@huawei.com>
Date: Mon, 31 Mar 2025 11:12:49 +0800
From: Yicong Yang <yangyicong@...wei.com>
To: Qinxin Xia <xiaqinxin@...wei.com>
CC: <yangyicong@...ilicon.com>, <catalin.marinas@....com>, <will@...nel.org>,
	<naveen.n.rao@...ux.ibm.com>, <anil.s.keshavamurthy@...el.com>,
	<davem@...emloft.net>, <mhiramat@...nel.org>, <linuxarm@...wei.com>,
	<linux-kernel@...r.kernel.org>, <fanghao11@...wei.com>,
	<prime.zeng@...ilicon.com>, <xuwei5@...wei.com>,
	<jonathan.cameron@...wei.com>, Barry Song <baohua@...nel.org>,
	<chris.zjh@...wei.com>
Subject: Re: [PATCH v7] arm64: kprobe: Enable OPTPROBE for arm64

On 2025/3/25 20:06, Qinxin Xia wrote:
> 
> 在 2025/3/17 12:01, Yicong Yang 写道:
>> On 2025/2/16 15:00, Qinxin Xia wrote:
>>> This patch introduce optprobe for ARM64. In optprobe, probed
>>> instruction is replaced by a branch instruction to trampoline.
>>>
>>> Performance of optprobe on Hip08 platform is test using kprobe
>>> example module to analyze the latency of a kernel function,
>>> and here is the result:
>>>

[...]

>>> +
>>> +void optprobe_optimized_callback(struct optimized_kprobe *op, struct pt_regs *regs)
>> need to be static.
> ok, I will fix it in the next version.
> It must be referenced by 'optprobe_trampoline.S' and cannot be covered by the static scope.

Then it should be marked as "asmlinkage" and declared in the header.

>>> +{
>>> +    if (kprobe_disabled(&op->kp))
>>> +        return;
>>> +
>>> +    guard(preempt)();
>>> +
>>> +    if (kprobe_running()) {
>>> +        kprobes_inc_nmissed_count(&op->kp);
>>> +    } else {
>>> +        __this_cpu_write(current_kprobe, &op->kp);
>>> +        get_kprobe_ctlblk()->kprobe_status = KPROBE_HIT_ACTIVE;
>>> +        opt_pre_handler(&op->kp, regs);
>>> +        __this_cpu_write(current_kprobe, NULL);
>>> +    }
>>> +}
>>> +NOKPROBE_SYMBOL(optprobe_optimized_callback)