linux-kernel - Re: [PATCH] ASoC: codec: ak5386: Convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250331115451.GB6762@nxa18884-linux>
Date: Mon, 31 Mar 2025 19:54:51 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, Peng Fan <peng.fan@....com>,
	"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <linux-sound@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:GPIO SUBSYSTEM:Keyword:(devm_)?gpio_(request|free|direction|get|set)" <linux-gpio@...r.kernel.org>,
	krzk@...nel.org
Subject: Re: [PATCH]  ASoC: codec: ak5386: Convert to GPIO descriptors

On Mon, Mar 31, 2025 at 10:19:12AM +0300, Andy Shevchenko wrote:
>On Mon, Mar 31, 2025 at 02:03:59PM +0800, Peng Fan wrote:
>> On Fri, Mar 28, 2025 at 03:33:11PM +0200, Andy Shevchenko wrote:
>> >On Fri, Mar 28, 2025 at 07:39:17PM +0800, Peng Fan (OSS) wrote:
>
>...
>
>> >>  The Documentation/devicetree/bindings/sound/ak5386.txt not specify
>> >>  polarity(this seems bug), so per code and datasheet, I think it
>> >>  should be active-high. I could add a quirk in gpiolib-of to force
>> >>  active-high or acitive-low if you think needed.
>> >
>> >I don't think we need a quirk as long as the default is the same,
>> >I mean if the DTS is written without setting polarity, would it be
>> >active-high or active-low?
>> 
>> Per current gpio driver, of_gpio_n_cells should at least be 2,
>> Not find any driver using 1 in current linux tree.
>
>Yes...
>
>> Without polarity, I think of_xlate will not work as expected.
>
>...and yes, but how is it related to my comment? The default should be sane
>to make it work, since there is no in-kernel user with wrong polarity there
>is nothing to fix.

I see, nothing to fix. Thanks for help reviewing.

Thanks,
Peng

>
>-- 
>With Best Regards,
>Andy Shevchenko
>
>
>